ringbuf: simplify ringReader #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code to correctly access the ring is currently split across two files an multiple functions which makes it hard to grasp what is going on. Strip out the overly generic Reader interface and only expose ringReader.readRecord. Also move discarding of samples into readRecord. This removes the amount of code and cuts down on the number of places where we call into sync/atomic. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
paulcacheux
approved these changes
Mar 14, 2024
|
👍 |
|
@lmb Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code to correctly access the ring is currently split across two files an multiple functions which makes it hard to grasp what is going on. Strip out the overly generic Reader interface and only expose ringReader.readRecord. Also move discarding of samples into readRecord.
This removes the amount of code and cuts down on the number of places where we call into sync/atomic.