program: fix LINUX_HAS_SYSCALL_WRAPPER use with bpf_tracing.h #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpf_tracing.h defines LINUX_HAS_SYSCALL_WRAPPER as a boolean:
extern _Bool LINUX_HAS_SYSCALL_WRAPPER __kconfig;
Our kconfig fixup code currently expects a uint32 and therefore
bails out with the following error:
resolve .kconfig: variable LINUX_HAS_SYSCALL_WRAPPER must be
a 32 bits integer, got Int:"_Bool"
Fix this by changing the code to expect a one byte integer instead.
A cursory search on Sourcegraph shows no open source users of uint32.
This makes sense since the variable is meant to be consumed via the
macros from bpf_tracing.h.
Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
|
Went for this simpler fix instead, since I think the likelihood of breaking anyone is low. |
|
I think the fix for this should match what We also have no guarantee that |
|
Do you feel like contributing the proper fix? Otherwise I'll go with this, on the basis that right now HAS_SYSCALL_WRAPPER is broken in the most common use case. I don't have time to investigate the full fix right now. P.S. I need this to be able to fix our section name parsing. |
|
Absolutely, I will push a proper fix in a few minutes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bpf_tracing.h defines LINUX_HAS_SYSCALL_WRAPPER as a boolean:
Our kconfig fixup code currently expects a uint32 and therefore bails out with the following error:
Fix this by changing the code to expect a one byte integer instead. A cursory search on Sourcegraph shows no open source users of uint32. This makes sense since the variable is meant to be consumed via the macros from bpf_tracing.h.