pkg/bpf: generate ASM output if debug enabled #599
Conversation
daemon/daemon.go
Outdated
| @@ -198,6 +198,10 @@ func (d *Daemon) PolicyEnabled() bool { | |||
| return d.conf.Opts.IsEnabled(endpoint.OptionPolicy) | |||
| } | |||
|
|
|||
| func (d *Daemon) GetDebug() bool { | |||
There was a problem hiding this comment.
exported method Daemon.GetDebug should have comment or be unexported
daemon/daemon.go
Outdated
| @@ -198,6 +198,10 @@ func (d *Daemon) PolicyEnabled() bool { | |||
| return d.conf.Opts.IsEnabled(endpoint.OptionPolicy) | |||
| } | |||
|
|
|||
| func (d *Daemon) GetDebug() bool { | |||
There was a problem hiding this comment.
exported method Daemon.GetDebug should have comment or be unexported
There was a problem hiding this comment.
I would pay more attention to hound if they'd use a puppy as a logo but we should add a comment to the function nevertheless.
There was a problem hiding this comment.
Will do - I'll only add reviewers after I placate the hound in the future :)
daemon/daemon.go
Outdated
| @@ -198,6 +198,10 @@ func (d *Daemon) PolicyEnabled() bool { | |||
| return d.conf.Opts.IsEnabled(endpoint.OptionPolicy) | |||
| } | |||
|
|
|||
| func (d *Daemon) GetDebug() bool { | |||
There was a problem hiding this comment.
I would pay more attention to hound if they'd use a puppy as a logo but we should add a comment to the function nevertheless.
46e7006 to
a7b60eb
Compare
daemon/daemon.go
Outdated
| @@ -198,6 +198,11 @@ func (d *Daemon) PolicyEnabled() bool { | |||
| return d.conf.Opts.IsEnabled(endpoint.OptionPolicy) | |||
| } | |||
|
|
|||
| // GetDebug returns whether if debug mode is enabled. | |||
| func (d *Daemon) GetDebug() bool { | |||
There was a problem hiding this comment.
Why not DebugEnabled()? In consistency with the DryModeEnabled() and TracingEnabled()
There was a problem hiding this comment.
Fixed in latest upload.
pkg/endpoint: add DebugEnabled to Owner interface daemon: regenerate bindata to account for changes in pkg/bpf/join_ep.sh Add DebugEnabled to Owner interface, implement in daemon, and utilize this method to determine whether debug mode is enabled to pass in as a parameter to join_ep.sh to generate ASM when BPF is generated. Signed-off by: Ian Vernon <ian@covalent.io>
a7b60eb to
2c70c0d
Compare
I think this is fine to get started. There is no code generation for these static programs so one can always invoke clang manually to generate it. |
pkg/endpoint: add GetDebug to Owner interface
daemon: regenerate bindata to account for changes in pkg/bpf/join_ep.sh
Add GetDebug to Owner interface, implement in daemon, and utilize this method to determine whether debug mode is enabled to pass in as a parameter to join_ep.sh to generate ASM when BPF is generated.
Fixes #429
Signed-off by: Ian Vernon ian@covalent.io