Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: riscv64 #24436

Closed
wants to merge 3 commits into from
Closed

feat: riscv64 #24436

wants to merge 3 commits into from

Conversation

ernado
Copy link

@ernado ernado commented Mar 17, 2023 •
edited
Loading

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.

Fixes: #24434

Add riscv64 support.

WIP

Blockers:

@maintainer-s-little-helper
Copy link

Commit b0915a8f366263fe1a21d205670111041523575f does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 17, 2023
@ernado ernado had a problem deploying to release-base-images March 17, 2023 18:36 — with GitHub Actions Error
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Mar 17, 2023
@ernado
feat: add riscv64
61dd6f0 
Signed-off-by: Aleksandr Razumov <ernado@ya.ru>
@maintainer-s-little-helper
Copy link

Commit b0915a8f366263fe1a21d205670111041523575f does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@ernado ernado had a problem deploying to release-base-images March 17, 2023 18:37 — with GitHub Actions Error
@ernado ernado mentioned this pull request Mar 17, 2023
Closed
@joestringer joestringer added the release-note/major This PR introduces major new functionality to Cilium. label Mar 17, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 17, 2023
@joestringer joestringer removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Mar 17, 2023
@ernado @joestringer
Update .github/workflows/build-images-base.yaml
92ec315 
Co-authored-by: Joe Stringer <joestringernz@gmail.com>
Signed-off-by: Aleksandr Razumov <ernado@ya.ru>
@ernado ernado had a problem deploying to release-base-images March 17, 2023 22:17 — with GitHub Actions Error
@ernado
fix: typo
7bfce39 
Signed-off-by: Aleksandr Razumov <ernado@ya.ru>
@ernado ernado had a problem deploying to release-base-images March 18, 2023 11:19 — with GitHub Actions Failure
@github-actions
Copy link

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Apr 18, 2023
@ernado ernado closed this Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer left review comments

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. release-note/major This PR introduces major new functionality to Cilium. stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CFP: Support linux/riscv64
2 participants
@ernado @joestringer