Fix cilium bpf policy list to print l4 ports
#2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
298d226 to
0a9cf8c
Compare
houndci-bot
reviewed
Dec 6, 2017
| @@ -27,7 +27,7 @@ var protoNames = map[int]string{ | |||
| 58: "ICMPv6", | |||
| } | |||
|
|
|||
| var protoIDs = map[string]U8proto{ | |||
| var ProtoIDs = map[string]U8proto{ | |||
There was a problem hiding this comment.
exported var ProtoIDs should have comment or be unexported
4c80c25 to
50e1958
Compare
raybejjani
approved these changes
Dec 7, 2017
ianvernon
approved these changes
Dec 7, 2017
Signed-off-by: Joe Stringer <joestringernz@gmail.com>
Signed-off-by: Joe Stringer <joestringernz@gmail.com>
I keep on trying to "get" a policy for a specific endpoint, then get told it's not a command. Alias "get" to "list" so it's harder to trip over. Signed-off-by: Joe Stringer <joe@covalent.io>
Signed-off-by: Joe Stringer <joestringernz@gmail.com>
Previously there was no way to add/delete policy map entries with l4 ports/protocols specified. This commit adds support, using the standard "port/proto" format, eg "80/TCP". Signed-off-by: Joe Stringer <joe@covalent.io>
50e1958 to
80e109f
Compare
In the API, it's often allowed to add/delete policy for multiple protocols by omitting the protocol and just specifying the port. Rather than adding an entry for protocol 0, attempt to add/delete entries for all common known protocols. Signed-off-by: Joe Stringer <joe@covalent.io>
80e109f to
f247e93
Compare
jrajahalme
approved these changes
Dec 7, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1941
Tasks:
--jsonbpf policy add/deleteto support l4port/proto