Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gsg-k8s Docs to include simplified steps with pod & DNS names. #2254

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Update gsg-k8s Docs to include simplified steps with pod & DNS names. #2254

merged 1 commit into from
Jan 4, 2018

Conversation

techcet
Copy link
Contributor

@techcet techcet commented Dec 5, 2017 •
edited by tgraf
Loading

Signed-off-by: Cynthia Thomas cynthia@covalent.io

Use DNS names in getting started guides

@techcet techcet requested a review from a team as a code owner December 5, 2017 02:43
@techcet techcet requested a review from a team December 5, 2017 02:43
@tgraf tgraf added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Dec 5, 2017
tgraf
tgraf requested changes Dec 5, 2017
View reviewed changes
examples/minikube/demo.yaml Outdated
metadata:
labels:
id: app2
spec:
containers:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is off now. I'm surprised that this actually works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked before, but I tightened up the indentation anyhow.

@techcet techcet changed the title Update gsg-k8s Docs to include simplied steps with pod & DNS names. Update gsg-k8s Docs to include simplified steps with pod & DNS names. Dec 6, 2017
@tgraf
Copy link
Member

tgraf commented Dec 21, 2017 •
edited
Loading

Rebased and squashed

@techcet techcet requested a review from a team as a code owner December 21, 2017 13:16
@raybejjani
Copy link
Contributor

rebased

@techcet
Update gsg-k8s Docs to include simplied steps with pod & DNS names.
2c2101a 
Signed-off-by: Cynthia Thomas <cynthia@covalent.io>
@manalibhutiyani
Copy link

Rebased.

@manalibhutiyani
Copy link

All review comments are addressed. Waiting for jenkins and will merge after that.

@manalibhutiyani manalibhutiyani merged commit e1ce690 into master Jan 4, 2018
@manalibhutiyani manalibhutiyani deleted the gsg-k8s-120417 branch January 4, 2018 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgraf tgraf tgraf requested changes

@manalibhutiyani manalibhutiyani manalibhutiyani approved these changes

@ianvernon ianvernon ianvernon approved these changes

@aalemayhu aalemayhu aalemayhu approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@techcet @tgraf @raybejjani @manalibhutiyani @aalemayhu @ianvernon @aanm