-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: make the GitHub URLs depend on the current branch #1764
Conversation
@scanf Did you generate this locally with sphinx to verify it works? |
@tgraf Are you seeing anything wrong with the output? Did not see any issues. Was testing it on a different server, rendered below https://alemayhu.com/cilium-staging/gettingstarted.html#getting-started-using-kubernetes |
Tested locally now and works for local branches (X), but not for remote branches (origin/X). So git is returning HEAD for those, but this shouldn't matter assuming the branches are locally checked out on read the docs. |
The only minor issue I can see is that the preformatted boxes are now rendered differently in my browser. The boxes with the links are rendered in a bigger font. Not an issue though. |
Noticed the font and frame mismatch as well. So we are changing the default because the |
I think this is fine. File a github issue with the doc tag so we don't forget about this. I think eventually we want to tackle things like these. |
@joestringer The tests failed. Do you think it is related with the L7 changes we found a week ago? @scanf Can you rebase? |
@aanm Rebased |
Documentation/install.rst
Outdated
$ vim cilium.yaml | ||
[adjust the etcd address] | ||
|
||
After configuring the ``cilium`` ConfigMap_ it is time to deploy it using | ||
After configuring the ``cilium`` ConfigMap it is time to deploy it using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the link to the ConfigMap?
Using git to retrieve the current branch and then storing it in the epilogue where it's globally available. This can later be moved should there be a conflicts on the names. Since the base URL is a variable now and used in the blocks, had to change to using a `parsed-literal` so they are rendered. One downside to this is that we no longer get the consistent frame around the text like the code blocks. Also fix a couple of minor issues in the install guide. Closes: #1755 (Make URLs version specific to provide backwards compatibility in docs) Signed-off-by: Alexander Alemayhu <alexander@alemayhu.com>
Can you add the link to the ConfigMap?
Added link to the kubernetes docs.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add this comment, so it's removed from review queue. Please ignore.
Using git to retrieve the current branch and then storing it in the
epilogue where it's globally available. This can later be moved should
there be a conflicts on the names. Since the base URL is a variable now
and used in the blocks, had to change to using a
parsed-literal
sothey are rendered. One downside to this is that we no longer get the
consistent frame around the text like the code blocks.
Closes: #1755 (Make URLs version specific to provide backwards compatibility in docs)
Signed-off-by: Alexander Alemayhu alexander@alemayhu.com