Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement changing the number of render threads without restarting Chunky. #1113

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

ThatRedox
Copy link
Member

@ThatRedox ThatRedox commented Dec 31, 2021

  • RenderManager now has an optional method to setThreadCount
  • Implement changing the number of threads in DefaultRenderManager and RenderWorkerPool
    • Render workers are now stored in an ArrayList, workers are sequentially assigned id's and seeds.
    • Replace RenderWorkerPool.threads with a getThreadCount method.
    • Update interrupt logic and work waiting logic to support killing zombie workers.
  • Allow for overwriting the common thread pool to change the number of threads.
  • Update advanced tab to support changing the number of threads.

ThatRedox and others added 2 commits April 16, 2023 16:07
# Conflicts:
#	chunky/src/java/se/llbit/chunky/ui/render/tabs/AdvancedTab.java
#	chunky/src/test/se/llbit/chunky/renderer/DeadlockTest.java
@ThatRedox
Copy link
Member Author

Should probably do a quick test before merging, its been a while.

@leMaik
Copy link
Member

leMaik commented Mar 4, 2024

image

@leMaik leMaik merged commit 29aa734 into chunky-dev:master Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants