Remove predicate.buildConfig.tasks[i].ref field

Related to tektoncd#436 (comment). Prior, pipeline level provenance had a `ref` field in the `predicate.buildConfig` section. In this commit, we remove this `ref` field from buildconfig in favor of `buildConfig.tasks[i].invocation.configSource` tektoncd#554 because configsource should be enough to record the source information that we need to track the origin of the remote definitions. Since `predicate.buildConfig` is pretty much free text, this deletion shouldn't introduce backward incompatible changes. Signed-off-by: Chuang Wang <chuangw@google.com>
chuangw6 · Nov 28, 2022 · d6f0d66 · d6f0d66
1 parent 40b43e9
commit d6f0d66
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 52 deletions.
diff --git a/pkg/chains/formats/intotoite6/intotoite6_test.go b/pkg/chains/formats/intotoite6/intotoite6_test.go
@@ -172,12 +172,8 @@ func TestPipelineRunCreatePayload(t *testing.T) {
 			BuildConfig: pipelinerun.BuildConfig{
 				Tasks: []pipelinerun.TaskAttestation{
 					{
-						Name:  "git-clone",
-						After: nil,
-						Ref: v1beta1.TaskRef{
-							Name: "git-clone",
-							Kind: "ClusterTask",
-						},
+						Name:       "git-clone",
+						After:      nil,
 						StartedOn:  e1BuildStart,
 						FinishedOn: e1BuildFinished,
 						Status:     "Succeeded",
@@ -219,12 +215,8 @@ func TestPipelineRunCreatePayload(t *testing.T) {
 						},
 					},
 					{
-						Name:  "build",
-						After: []string{"git-clone"},
-						Ref: v1beta1.TaskRef{
-							Name: "build",
-							Kind: "ClusterTask",
-						},
+						Name:       "build",
+						After:      []string{"git-clone"},
 						StartedOn:  e1BuildStart,
 						FinishedOn: e1BuildFinished,
 						Status:     "Succeeded",
@@ -360,12 +352,8 @@ func TestPipelineRunCreatePayloadChildRefs(t *testing.T) {
 			BuildConfig: pipelinerun.BuildConfig{
 				Tasks: []pipelinerun.TaskAttestation{
 					{
-						Name:  "git-clone",
-						After: nil,
-						Ref: v1beta1.TaskRef{
-							Name: "git-clone",
-							Kind: "ClusterTask",
-						},
+						Name:       "git-clone",
+						After:      nil,
 						StartedOn:  e1BuildStart,
 						FinishedOn: e1BuildFinished,
 						Status:     "Succeeded",
@@ -407,12 +395,8 @@ func TestPipelineRunCreatePayloadChildRefs(t *testing.T) {
 						},
 					},
 					{
-						Name:  "build",
-						After: []string{"git-clone"},
-						Ref: v1beta1.TaskRef{
-							Name: "build",
-							Kind: "ClusterTask",
-						},
+						Name:       "build",
+						After:      []string{"git-clone"},
 						StartedOn:  e1BuildStart,
 						FinishedOn: e1BuildFinished,
 						Status:     "Succeeded",

diff --git a/pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go b/pkg/chains/formats/intotoite6/pipelinerun/pipelinerun.go
@@ -140,10 +140,6 @@ func buildConfig(pro *objects.PipelineRunObject, logger *zap.SugaredLogger) Buil
 			Results:    tr.Status.TaskRunResults,
 		}
 
-		if t.TaskRef != nil {
-			task.Ref = *t.TaskRef
-		}
-
 		tasks = append(tasks, task)
 		if i < len(pSpec.Tasks) {
 			last = task.Name

diff --git a/pkg/chains/formats/intotoite6/pipelinerun/provenance_test.go b/pkg/chains/formats/intotoite6/pipelinerun/provenance_test.go
@@ -76,12 +76,8 @@ func TestBuildConfig(t *testing.T) {
 	expected := BuildConfig{
 		Tasks: []TaskAttestation{
 			{
-				Name:  "git-clone",
-				After: nil,
-				Ref: v1beta1.TaskRef{
-					Name: "git-clone",
-					Kind: "ClusterTask",
-				},
+				Name:       "git-clone",
+				After:      nil,
 				StartedOn:  e1BuildStart,
 				FinishedOn: e1BuildFinished,
 				Status:     "Succeeded",
@@ -123,12 +119,8 @@ func TestBuildConfig(t *testing.T) {
 				},
 			},
 			{
-				Name:  "build",
-				After: []string{"git-clone"},
-				Ref: v1beta1.TaskRef{
-					Name: "build",
-					Kind: "ClusterTask",
-				},
+				Name:       "build",
+				After:      []string{"git-clone"},
 				StartedOn:  e1BuildStart,
 				FinishedOn: e1BuildFinished,
 				Status:     "Succeeded",
@@ -252,12 +244,8 @@ func TestBuildConfigTaskOrder(t *testing.T) {
 			expected := BuildConfig{
 				Tasks: []TaskAttestation{
 					{
-						Name:  "git-clone",
-						After: nil,
-						Ref: v1beta1.TaskRef{
-							Name: "git-clone",
-							Kind: "ClusterTask",
-						},
+						Name:       "git-clone",
+						After:      nil,
 						StartedOn:  e1BuildStart,
 						FinishedOn: e1BuildFinished,
 						Status:     "Succeeded",
@@ -299,12 +287,8 @@ func TestBuildConfigTaskOrder(t *testing.T) {
 						},
 					},
 					{
-						Name:  "build",
-						After: []string{"git-clone"},
-						Ref: v1beta1.TaskRef{
-							Name: "build",
-							Kind: "ClusterTask",
-						},
+						Name:       "build",
+						After:      []string{"git-clone"},
 						StartedOn:  e1BuildStart,
 						FinishedOn: e1BuildFinished,
 						Status:     "Succeeded",