Skip to content

Commit

Permalink
Fix TACA for handling 10X UMI cases by BCL Convert
Browse files Browse the repository at this point in the history
  • Loading branch information
chuan-wang committed Oct 24, 2024
1 parent 9ae72bd commit 2581461
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
4 changes: 4 additions & 0 deletions VERSIONLOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# TACA Version Log

## 20241024.1

Fix TACA for handling 10X UMI cases by BCL Convert

## 20241016.1

Switch to tarball and skip compression
Expand Down
6 changes: 4 additions & 2 deletions taca/illumina/Standard_Runs.py
Original file line number Diff line number Diff line change
Expand Up @@ -676,11 +676,11 @@ def _compute_base_mask(
if is_dual_index or sample_type == "10X_SINGLE":
if (
sample_type == "10X_SINGLE"
): # Case of 10X single indexes, demultiplex the whole index 2 cycles as FastQ for bcl2fastq. But this has to be ignored for bclconvert
): # Case of 10X single indexes, demultiplex the whole index 2 cycles as FastQ of read for bcl2fastq. For BCL-convert it is treated as UMI
if self.software == "bcl2fastq":
bm.append("Y" + str(cycles))
elif self.software == "bclconvert":
bm.append("N" + str(cycles))
bm.append("U" + str(cycles))
else:
raise RuntimeError("Unrecognized software!")
else:
Expand Down Expand Up @@ -878,6 +878,8 @@ def _generate_samplesheet_subset(
if software == "bclconvert":
output += f"[Settings]{os.linesep}"
output += "OverrideCycles,{}{}".format(";".join(base_mask), os.linesep)
if any("U" in bm for bm in base_mask):
output += f"TrimUMI,0{os.linesep}"

if CONFIG.get("bclconvert"):
if CONFIG["bclconvert"].get("settings"):
Expand Down

0 comments on commit 2581461

Please sign in to comment.