-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localtime using tz-rs #656
Conversation
Thanks for working on this! I'm not yet sure if this is the right direction, will have to dig into it more. |
Thanks for enabling CI @djc - I'll try and get the CI passing - then I recognize there are a bunch more things to figure out, this is intended as a proof of concept. If this is later decided to be a good solution, I'll go through and add more documentation etc. Potential issues:
Other options:
|
3f765e7
to
71e285f
Compare
For information, I have reduced the MSRV to |
71e285f
to
439c98a
Compare
Thanks @x-hgg-x - I've updated to the latest version of |
f1f96f8
to
f78e84f
Compare
e885884
to
db5ac0a
Compare
Thanks for working on this! Unfortunately, I'm inclined to take a different direction, see #677. Would be happy to get your feedback. |
This is a potential way to solve the CVE-2020-0159. This uses the library
tz-rs
to read the time zone information file and calculate the local offset from the information contained within.tz-rs
is quite comprehensive as leap second handling has been implemented, however there are some outstanding questions on how to handle this infrom_local_datetime
(should we assume the local datetime does or doesn't include leap seconds?).Thanks for contributing to chrono!
about adding the PR number)
we can't reintroduce it?