Updated to add a theme and address more syntax edge cases #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a theme to match as close as possible to Chronicle's native editor. Updated README to reflect loading the theme, updated example.png to show the new UI elements.
Fixed new example image locale.
…on_expression change to prevent breakage of language constructs within parenthesis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will set a theme to mirror (as close as I could get it) to the Chronicle native UI. There could still be a few edge cases not caught by the pattern matches, but almost all of them within the current Yara-L 2.0 spec should be operational.
I also adjusted the README to reflect manually loading the theme if it doesn't work for some reason via the activation, and added a new screenshot of the theme; the rule utilized is https://github.com/chronicle/detection-rules/blob/main/community/threat_intel/hash_prevalence.yaral.
Feel free to edit/modify however you'd like.
Thanks!
Dan Lussier