Vue Guide for Storybook v6 #405
Conversation
There was a problem hiding this comment.
@andre-brdoch left two items that need some work. Other than that we're good to go. Can't thank you enough for this. Really stoked to get this one merged and shared with the community. Awesome job you did here :)
|
Hi @jonniebigodes, thank you so much for pointing this out! Totally missed that I was not actually running the tests 🙃 Thanks for letting me know, this is great to know for the future. I applied the fixes, let me know if there is anything left to do 😃 Have a good one! |
There was a problem hiding this comment.
@andre-brdoch when you're able address the two items i pointed out regarding the name of the branches and we'll be good to go.
Let me know once you've applied them and i'll get this merged.
Stay safe
|
@jonniebigodes done! 👍 |
|
@andre-brdoch going to merge it as is. Thank you for this much deserved update to the tutorial. We really appreciate it. 👍 Stay safe. |
Hey! I updated the Vue guide to storybook v6 😃
Snippets can be tested here: https://github.com/andre-brdoch/learnstorybook-v6-vue
@jonniebigodes already reviewed the snippets there 😄
I noticed that some chapters like the one for testing or deploys were quite different in the React guide. I assumed the React guide is most up to date, so i adapted those for Vue. Let me know if that was not wanted!
I added the snippets only to the english version, since it probably makes more sense to update snippets and texts simultanously for the other languages. Have a good day 👍