Prebundle react-confetti dependency #348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JReinhold
approved these changes
Dec 12, 2024
|
At Storybook we ended up using a different confetti library, so I'll close this PR while suggest that we use the same library here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup work for storybookjs/storybook#29996
This way we can support React 19 without relying on react-confetti to make an update
📦 Published PR as canary version:
3.3.0--canary.348.e32cb15.0✨ Test out this PR locally via:
npm install @chromatic-com/storybook@3.3.0--canary.348.e32cb15.0 # or yarn add @chromatic-com/storybook@3.3.0--canary.348.e32cb15.0