Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLN] Make memberlist reset() not wait longer than it needs to #2473

Merged
merged 1 commit into from
Jul 8, 2024
Merged

[CLN] Make memberlist reset() not wait longer than it needs to #2473

merged 1 commit into from
Jul 8, 2024
+16 −12

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Jul 8, 2024 •
edited
Loading

Description of changes

Objective of this PR is making CI faster by reducing waiting time to the minimal required time

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Change go memberlist reconcilation to be higher frequency
    • Change the memberlist reset() logic in frontend to use a threading event to only wait until the ML is updated
    • Now waits for ~0.3 seconds instead of 5
  • New functionality
    • None

Test plan

How are these changes tested?
These changes are covered by existing tests.

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@HammadB HammadB requested review from sanketkedia and codetheweb July 8, 2024 21:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@HammadB HammadB merged commit 1b6483d into main Jul 8, 2024
66 checks passed
@HammadB HammadB mentioned this pull request Jul 9, 2024
Merged
1 task
HammadB added a commit that referenced this pull request Jul 9, 2024
@HammadB
[TST] ML sleep (#2480)
a7479a6 
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
- #2473 introduced a change to wait less, this flaps for some reason. In
the interest of speeding up the test but not wasting time on debugging
this as its only a test harness related change, just sleep to let the ML
converge.
 - New functionality
	 - ...

## Test plan
*How are these changes tested?*

- [ ] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Documentation Changes
*Are all docstrings for user-facing APIs updated if required? Do we need
to make documentation changes in the [docs
repository](https://github.com/chroma-core/docs)?*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketkedia sanketkedia Awaiting requested review from sanketkedia

@codetheweb codetheweb Awaiting requested review from codetheweb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HammadB