-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Fix issues + add sync point to test embeddings #2397
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
98745be
to
ded33d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would love to grab 5 minutes just to make sure I understand the logic changes in hnsw_knn.rs
1543d38
to
99f56d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good minus comments around mixin and the blockfile changes
3ecfdfa
to
78df19b
Compare
*Summarize the changes made by this PR.* - Improvements & Bug fixes - Fixes allowed_ids and disallowed_ids to also take care of updates/deletes/upserts. For e.g. if there is an update on the log that does not update the embedding and it is in the query list then today we are never going to return this record even if it is in the top k - Adds sync points to test_embeddings + increase test timeout - Adds another rule in test_embeddings for compaction - Suppresses health check warning for filtering too much - Fixes the case when trying to commit and flush an empty block (can happen due to deletes). Sparse index start key can also get changed to something that is not SparseIndexDelimiter::Start. We decided to go ahead with flushing a dummy block if blockfile becomes fully empty so that our segment abstraction is only uninitialized until the first compaction; post that it is always initialized albeit with empty block - Fixes a bug in FTS delete document where we were incorrectly panicing - Fixes a bug in record segment apply materialization where for deletes and updates we missed writing the max offset id - Updates to metadata segment were missing updating the document and were only updating the metadata - Don't return error from the metadata segment if document is supplied as None for an update - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust None
Description of changes
Summarize the changes made by this PR.
Test plan
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
None