-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Fix cross version compatibility 0.5.0 or lower with 0.5.1+ #2378
[BUG]: Fix cross version compatibility 0.5.0 or lower with 0.5.1+ #2378
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
We don't usually make changes for sake of forward compatibility but this makes sense. |
Don't we have to do this in other methods too - like get_collection? |
What about list_collections? |
What about https://github.com/chroma-core/chroma/blob/main/chromadb/api/async_fastapi.py? Can we encapsulate this so we aren't repeating it everywhere? cc @codetheweb |
…ionModel for both sync and async clients.
Done. |
@HammadB, shouldn't |
CollectionCommon is just a base class with some helpers that the async/sync variants inherent from. I don't think it needs to care about those fields unless I'm missing something. |
|
…roma-core#2378) Closes chroma-core#2377 chroma-core#2379 ## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Making dimension and version lookup optional in the Collection model creation in fastapi client ## Test plan *How are these changes tested?* - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes N/A
Closes #2377 #2379
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
N/A