fix: segfault in minisat #75

chrjabs · 2024-03-29T07:31:52Z

newVar method was not virtual so core::newVar was called instead of simp::newVar

resolves #74

`newVar` method was not virtual so `core::newVar` was called instead of `simp::newVar` resolves #74

chrjabs · 2024-03-29T12:16:01Z

Add tests that would have caught this before merging.

chrjabs · 2024-04-04T08:16:41Z

Also resolves #76

add tests that would have caught #74

resolves #76

fix: segfault in minisat

e09121e

`newVar` method was not virtual so `core::newVar` was called instead of `simp::newVar` resolves #74

chrjabs force-pushed the bugfix/minisat-simp-segfault branch 2 times, most recently from a72fe66 to ddd6e61 Compare April 4, 2024 08:16

chrjabs added 3 commits April 4, 2024 11:25

test: minisat segfault tests

341d979

add tests that would have caught #74

perf: add BufWriter when writing to file

0ea68ca

resolves #76

chore: clippy lints

f78c6d2

chrjabs force-pushed the bugfix/minisat-simp-segfault branch from b71aba0 to f78c6d2 Compare April 4, 2024 08:25

chrjabs merged commit d768c48 into main Apr 4, 2024
36 checks passed

chrjabs deleted the bugfix/minisat-simp-segfault branch April 4, 2024 08:36

Provide feedback