Skip to content

Commit

Permalink
PR: implemented suggestions and applied reviews
Browse files Browse the repository at this point in the history
  • Loading branch information
nfbruns committed Jul 1, 2024
1 parent 1544980 commit fcfa9df
Show file tree
Hide file tree
Showing 8 changed files with 23 additions and 17 deletions.
8 changes: 2 additions & 6 deletions .github/workflows/batsat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: BatSat

on:
push:
branches: [ "main" ]
branches: [ "main", "next-major" ]
pull_request:
branches: [ "main" ]
branches: [ "main", "next-major" ]

env:
CARGO_TERM_COLOR: always
Expand All @@ -26,9 +26,5 @@ jobs:
shared-key: "build-test"
- name: Cargo build
run: cargo build -p rustsat-batsat --verbose
env:
CMAKE_BUILD_PARALLEL_LEVEL: ${{ fromJSON('["", "4"]')[matrix.os == 'macos-latest'] }}
- name: Cargo test
run: cargo test -p rustsat-batsat --verbose
env:
CMAKE_BUILD_PARALLEL_LEVEL: ${{ fromJSON('["", "4"]')[matrix.os == 'macos-latest'] }}
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
echo "failed for main crate"
return=false
fi
for dir in tools cadical kissat minisat glucose ipasir capi pyapi; do
for dir in tools cadical kissat minisat glucose batsat ipasir capi pyapi; do
cd ${dir}
if ! cargo rdme --check; then
echo "failed for ${dir}"
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/semver-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,7 @@ jobs:
uses: obi1kenobi/cargo-semver-checks-action@v2
with:
package: rustsat-ipasir
- name: BatSat
uses: obi1kenobi/cargo-semver-checks-action@v2
with:
package: rustsat-batsat
1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ members = [
"glucose",
"minisat",
"ipasir",
"batsat",
"solvertests",
"capi",
"pyapi",
Expand Down
6 changes: 2 additions & 4 deletions batsat/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,8 @@

All notable changes to this project will be documented in this file.

## [0.2.4] - 2024-04-10
## [0.1.0] - <Set Date When Releasing>

### 🚀 Features

- Implemented batsat api
Initial Release

<!-- generated by git-cliff -->
3 changes: 0 additions & 3 deletions batsat/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ readme = "README.md"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[features]
debug = []

[dependencies]
batsat = "0.5.0" # when changing this version, do not forget to update signature
anyhow.workspace = true
Expand Down
11 changes: 9 additions & 2 deletions batsat/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
//! # BatSat Solver Interface
//! # rustsat-batsat - Interface to the BatSat SAT Solver for RustSAT
//!
//! Interface to the [BatSat](https://github.com/c-cube/batsat) incremental SAT-Solver
//! Interface to the [BatSat](https://github.com/c-cube/batsat) incremental SAT-Solver to be used with the [RustSAT](https://github.com/chrjabs/rustsat) library.
//!
//! # BatSat Version
//!
//! The version of BatSat in this crate is Version 0.5.0.
#![warn(clippy::pedantic)]
#![warn(missing_docs)]

use batsat::{intmap::AsIndex, lbool, BasicSolver, SolverInterface};
use rustsat::{
Expand Down
5 changes: 5 additions & 0 deletions release-plz.toml
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,8 @@ git_release_enable = false
name = "rustsat-pyapi"
release = false
git_release_enable = false

[[package]]
name = "rustsat-batsat"
release = false
git_release_enable = false

0 comments on commit fcfa9df

Please sign in to comment.