docs(stark-ui): fix jsdoc in SvgViewBox directive. Cleanup code in un…

…it tests.
christophercr · Jul 27, 2018 · d82a11e · d82a11e
1 parent 0edae9b
commit d82a11e
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 12 deletions.
diff --git a/packages/stark-ui/src/modules/app-logo/components/app-logo.component.spec.ts b/packages/stark-ui/src/modules/app-logo/components/app-logo.component.spec.ts
@@ -1,5 +1,4 @@
 /*tslint:disable:completed-docs*/
-import { NO_ERRORS_SCHEMA } from "@angular/core";
 import { async, ComponentFixture, TestBed } from "@angular/core/testing";
 import { STARK_LOGGING_SERVICE, STARK_ROUTING_SERVICE } from "@nationalbankbelgium/stark-core";
 import { MockStarkLoggingService, MockStarkRoutingService } from "@nationalbankbelgium/stark-core/testing";
@@ -22,8 +21,7 @@ describe("AppLogoComponent", () => {
 				providers: [
 					{ provide: STARK_LOGGING_SERVICE, useValue: new MockStarkLoggingService() },
 					{ provide: STARK_ROUTING_SERVICE, useClass: MockStarkRoutingService }
-				],
-				schemas: [NO_ERRORS_SCHEMA] // tells the Angular compiler to ignore unrecognized elements and attributes
+				]
 			})
 				/**
 				 * Compile template and css

diff --git a/packages/stark-ui/src/modules/slider/components/slider.component.spec.ts b/packages/stark-ui/src/modules/slider/components/slider.component.spec.ts
@@ -1,6 +1,6 @@
 /* angular imports */
 import { async, ComponentFixture, TestBed } from "@angular/core/testing";
-import { Component, ViewChild, NO_ERRORS_SCHEMA, EventEmitter } from "@angular/core";
+import { Component, ViewChild, EventEmitter } from "@angular/core";
 
 /* jasmine imports */
 import Spy = jasmine.Spy;
@@ -64,8 +64,7 @@ describe("SliderController", () => {
 			providers: [
 				{ provide: STARK_LOGGING_SERVICE, useValue: new MockStarkLoggingService() },
 				{ provide: STARK_ROUTING_SERVICE, useClass: MockStarkRoutingService }
-			],
-			schemas: [NO_ERRORS_SCHEMA] // tells the Angular compiler to ignore unrecognized elements and attributes
+			]
 		}).compileComponents();
 	}));
 

diff --git a/packages/stark-ui/src/modules/svg-view-box/directives/svg-view-box.directive.spec.ts b/packages/stark-ui/src/modules/svg-view-box/directives/svg-view-box.directive.spec.ts
@@ -1,7 +1,7 @@
 /*tslint:disable:completed-docs*/
 import { ComponentFixture, fakeAsync, TestBed } from "@angular/core/testing";
 import { StarkSvgViewBoxDirective } from "./svg-view-box.directive";
-import { Component, DebugElement, NO_ERRORS_SCHEMA } from "@angular/core";
+import { Component, DebugElement } from "@angular/core";
 import { By } from "@angular/platform-browser";
 
 describe("SvgViewBoxDirective", () => {
@@ -33,8 +33,7 @@ describe("SvgViewBoxDirective", () => {
 
 	beforeEach(() => {
 		TestBed.configureTestingModule({
-			declarations: [StarkSvgViewBoxDirective, TestComponent],
-			schemas: [NO_ERRORS_SCHEMA]
+			declarations: [StarkSvgViewBoxDirective, TestComponent]
 		});
 	});
 

diff --git a/packages/stark-ui/src/modules/svg-view-box/directives/svg-view-box.directive.ts b/packages/stark-ui/src/modules/svg-view-box/directives/svg-view-box.directive.ts
@@ -5,16 +5,16 @@ import { AfterViewChecked, Directive, ElementRef, Input, Renderer2 } from "@angu
  */
 const directiveName: string = "[starkSvgViewBox]";
 
-@Directive({
-	selector: directiveName
-})
 /**
  * Directive to add the 'viewBox' attribute to an SVG element.
  * Specially useful to fix the issue with the Angular Material's MatIcon directive which prevents the icons from
  * being re-sized via CSS due to the 'viewBox' property not being added to the SVG element.
  * @link https://github.com/angular/material2/issues/4422
  * @link https://github.com/angular/material2/issues/5488
  */
+@Directive({
+	selector: directiveName
+})
 export class StarkSvgViewBoxDirective implements AfterViewChecked {
 	/**
 	 * Width and height to be set to the 'viewBox' attribute of the SVG element.