Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement LocalDateTime #260

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

chrisimcevoy
Copy link
Owner

As usual, large portions of this type were already implemented as a by-product of previous ports of other types.

This adds all the missing bits, including the TestLocalDateTime.cs port (at least, as much as it makes sense to do so).

It also fixes a couple of lurking bugs in _TimePeriodField which were unearthed along the way.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 99.77974% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.59%. Comparing base (6224e4d) to head (e847026).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pyoda_time/_local_date_time.py 99.13% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   96.46%   96.59%   +0.12%     
==========================================
  Files         263      263              
  Lines       20902    21318     +416     
==========================================
+ Hits        20164    20593     +429     
+ Misses        738      725      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisimcevoy chrisimcevoy merged commit 6329e0c into main Jan 29, 2025
9 checks passed
@chrisimcevoy chrisimcevoy deleted the feat/implement-local-date-time branch January 29, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant