Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement DateTimeZone #243

Merged
merged 3 commits into from
Jan 11, 2025
Merged

Conversation

chrisimcevoy
Copy link
Owner

Implements the vast majority of DateTimeZone functionality.

Not immediately sure what to do with the DateTimeZone.GetZoneIntervals() overload which accepts ZoneEqualityComparer.Options. I'll come back to that.

Relates to:

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 98.99598% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.22%. Comparing base (090452a) to head (553504f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pyoda_time/_date_time_zone.py 93.33% 3 Missing ⚠️
pyoda_time/_offset_date_time.py 95.83% 1 Missing ⚠️
pyoda_time/_zoned_date_time.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
+ Coverage   95.99%   96.22%   +0.22%     
==========================================
  Files         259      260       +1     
  Lines       19606    20081     +475     
==========================================
+ Hits        18821    19323     +502     
+ Misses        785      758      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Noticed in CodeCov that this module was ~98% covered... yikes.
@github-actions github-actions bot added the yaml label Jan 11, 2025
@chrisimcevoy chrisimcevoy merged commit 78f3c94 into main Jan 11, 2025
9 checks passed
@chrisimcevoy chrisimcevoy deleted the feat/implement-date-time-zone branch January 11, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant