Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulator dependency target, fix for Power architecture #5

Conversation

sathayen
Copy link

Description

Just repeating the PR #2 , now for cpp-simulator branch based on @chriseclectic 's suggestion.

Note: As these branches have significant code changes elsewhere, used git cherry-pick to pick relevant commits -- git cherry-pick -x <commit_hash>

  • This PR adds a new target to build dependencies (make depend) for the qasm-cpp-simulator. The dependencies are built using the information provided in the README. It has been tested on Ubuntu 16.04 only.
  • Fixes the compilation error on ppc64le (use of -march)
  • Fixes make sim target in qiskit-sdk-py/Makefile

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@chriseclectic chriseclectic merged this pull request into chriseclectic:cpp-simulator-refactor Mar 28, 2018
chriseclectic pushed a commit that referenced this pull request Mar 28, 2018
* new dependencies target (make depend) for the qasm-simulator-cpp

(cherry picked from commit 3b25390)

* changed to executable and bug fix

(cherry picked from commit ce8be89)

* assume yes for automatic pkg install

(cherry picked from commit 2cd7607)

* -march not supported on ppc64le. Use -mcpu instead

(cherry picked from commit 7cdab8f)

* bugfix

(cherry picked from commit 831692e)
chriseclectic pushed a commit that referenced this pull request Apr 4, 2018
* new dependencies target (make depend) for the qasm-simulator-cpp

(cherry picked from commit 3b25390)

* changed to executable and bug fix

(cherry picked from commit ce8be89)

* assume yes for automatic pkg install

(cherry picked from commit 2cd7607)

* -march not supported on ppc64le. Use -mcpu instead

(cherry picked from commit 7cdab8f)

* bugfix

(cherry picked from commit 831692e)
chriseclectic pushed a commit that referenced this pull request Apr 13, 2018
* new dependencies target (make depend) for the qasm-simulator-cpp

(cherry picked from commit 3b25390)

* changed to executable and bug fix

(cherry picked from commit ce8be89)

* assume yes for automatic pkg install

(cherry picked from commit 2cd7607)

* -march not supported on ppc64le. Use -mcpu instead

(cherry picked from commit 7cdab8f)

* bugfix

(cherry picked from commit 831692e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants