Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading clips and raw data not working suddenly #216

Closed
zmunro opened this issue Mar 19, 2018 · 1 comment · Fixed by #217
Closed

Downloading clips and raw data not working suddenly #216

zmunro opened this issue Mar 19, 2018 · 1 comment · Fixed by #217

Comments

@zmunro
Copy link
Contributor

zmunro commented Mar 19, 2018

Not sure what has changed in the past few days but the extension no longer lets you download clips or their raw data. I tried to use the helper script and run Helper.download_replays(1) and it looks like it works but nothing ever actually gets downloaded. Posted in the subreddit and Ping Tut has also been experiencing this issue. Please help :(

@chrahunt
Copy link
Owner

Hi, I have tested this and can confirm that it happens for me too. This is likely related to eligrey/FileSaver.js#408.

chrahunt added a commit that referenced this issue Mar 20, 2018
We use a branch that has a fixed version of FileSaver.js until
eligrey/FileSaver.js#411 gets merged.

Fixes #216.
chrahunt added a commit that referenced this issue Mar 20, 2018
* Update FileSaver to fix Chrome download issue.

We use a branch that has a fixed version of FileSaver.js until
eligrey/FileSaver.js#411 gets merged.

Fixes #216.

* Fix Travis build.

Per travis-ci/travis-ci#8836, their container infrastructure does not
support sandboxed Chrome. We don't want to switch to `sudo: required`
(for speed) so we use `no-sandbox` as suggested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants