Skip to content

Commit

Permalink
fix(scripts-beachball): dont override */9.0-alpha versions specified …
Browse files Browse the repository at this point in the history
…within apps during release (microsoft#28584)

* fix(beachball): dont override */9.0-alpha versions specified within apps during release

* chore: fix invalid apps dependency introduced by out of sync PR
  • Loading branch information
Hotell authored Jul 19, 2023
1 parent c3819e5 commit 8ba163a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion apps/perf-test-react-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@fluentui/react-avatar": "*",
"@fluentui/react-button": "*",
"@fluentui/react-field": "*",
"@fluentui/react-infobutton": "9.0.0-beta.42",
"@fluentui/react-infobutton": ">=9.0.0-alpha",
"@fluentui/react-persona": "*",
"@fluentui/react-provider": "*",
"@fluentui/react-spinbutton": "*",
Expand Down
2 changes: 1 addition & 1 deletion apps/vr-tests-react-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"@fluentui/react-field": "*",
"@fluentui/react-icons": "^2.0.203",
"@fluentui/react-image": "*",
"@fluentui/react-infobutton": "9.0.0-beta.42",
"@fluentui/react-infobutton": ">=9.0.0-alpha",
"@fluentui/react-input": "*",
"@fluentui/react-label": "*",
"@fluentui/react-link": "*",
Expand Down
4 changes: 2 additions & 2 deletions scripts/beachball/shared.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ export const config: typeof baseConfig & Required<Pick<BeachballConfig, 'changel
precommit: () => {
try {
const generators = [
// Fixes unwanted pre-release dependency bumps caused by beachball
'normalize-package-dependencies',
// Fixes any dependency mismatches caused by beachball scoping
'dependency-mismatch',
// Fixes unwanted pre-release dependency bumps caused by beachball - This needs to run last otherwise deps within apps will contain exact versions ( which dependency-mismatch generator update - TODO we need to fix it)
'normalize-package-dependencies',
];

generators.forEach(generator => {
Expand Down

0 comments on commit 8ba163a

Please sign in to comment.