Dockerfile to Enable Mono Based Choco Builds #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferventcoder
requested changes
Mar 10, 2017
There was a problem hiding this comment.
This looks good, can you make the following changes:
- Is it okay if we put these files in a subfolder or do they need to be at root? I'm not a big fan of having them in the root. Also, that folder should be docker/linux/Dockerfile to allow for a Windows Dockerfile to be added as well.
- Can you squash all commits down to one?
- When you squash the commits - add
(maint)to the commit and fix up your message to use a short summary followed by a commit body that explains what this is for more deeply.
|
Added more to that second bit. |
|
Thanks for reviewing.
|
Adds a dockerfile for the mono choco build. Adds the wrapper Bash script for easier choco commands in the container. Stores assets in a docker subfolder. Adds documentation on how to build the image yourself.
|
Hopefully that satisfies your change requests. |
|
That looks great! |
|
See this is still marked as needing changes. Anything else I can do? |
ferventcoder
approved these changes
Apr 26, 2017
|
No sir. All good to go. Merged in. Thanks! |
|
👍 Now we've got the right stuff in place for an official Docker Hub build! Excited for that next step. |
|
Linking bazelbuild/bazel#4559 for a +1. #1020 is a likely fix, since it would allow us to use supported mono containers which (presumably!) have up-to-date SSL certs within. |
This was referenced Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a Dockerfile and choco_wrapper script to enable easy Linux based choco.exe usage.
The Dockerfile copies the entire source tree into the container and then builds choco.exe using the build.sh script.
The choco_wrapper is copied into /usr/local/bin/choco and allows for easier execution of choco.exe using mono.
I suggest linking the repository to Docker Hub and releasing various versions of the Docker image using their build process.