Dockerfile add metadata with LABEL #2361
Labels
5 - Released
BuildAutomation
NO RELEASE NOTES
Should not be included in the release notes - not enhancing or fixing end product.
Milestone
Comments
TheCakeIsNaOH
added a commit
to TheCakeIsNaOH/choco
that referenced
this issue
Sep 17, 2021
Rework the Dockerfile for Linux. Move to a multi-stage build so the source code is not brought along into the final image (chocolatey#2364). Add build args to select the build script and mono version to use. Remove deprecated MAINTAINER instruction and add metadata with LABEL (chocolatey#2361). Add "choco.exe" to path, so both "choco" and "choco.exe" can be used, like Windows supports (chocolatey#2362). Change the install location to "/opt/chocolatey" as that is more in line with the Linux filesystem hierarchy (chocolatey#2360). Create the "lib" directory to prevent the warning about the directory not being found (chocolatey#2363). The choco_official_wrapper is used for official builds, where the "--allow-unofficial" argument is not needed.
TheCakeIsNaOH
added a commit
to TheCakeIsNaOH/choco
that referenced
this issue
Sep 17, 2021
Rework the Dockerfile for Linux. Move to a multi-stage build so the source code is not brought along into the final image (chocolatey#2364). Add build args to select the build script and mono version to use. Remove deprecated MAINTAINER instruction and add metadata with LABEL (chocolatey#2361). Add "choco.exe" to path, so both "choco" and "choco.exe" can be used, like Windows supports (chocolatey#2362). Change the install location to "/opt/chocolatey" as that is more in line with the Linux filesystem hierarchy (chocolatey#2360). Create the "lib" directory to prevent the warning about the directory not being found (chocolatey#2363). The choco_official_wrapper is used for official builds, where the "--allow-unofficial" argument is not needed.
gep13
pushed a commit
to TheCakeIsNaOH/choco
that referenced
this issue
Sep 17, 2021
Rework the Dockerfile for Linux. Move to a multi-stage build so the source code is not brought along into the final image (chocolatey#2364). Add build args to select the build script and mono version to use. Remove deprecated MAINTAINER instruction and add metadata with LABEL (chocolatey#2361). Add "choco.exe" to path, so both "choco" and "choco.exe" can be used, like Windows supports (chocolatey#2362). Change the install location to "/opt/chocolatey" as that is more in line with the Linux filesystem hierarchy (chocolatey#2360). Create the "lib" directory to prevent the warning about the directory not being found (chocolatey#2363). The choco_official_wrapper is used for official builds, where the "--allow-unofficial" argument is not needed.
gep13
pushed a commit
that referenced
this issue
Sep 21, 2021
Rework the Dockerfile for Linux. Move to a multi-stage build so the source code is not brought along into the final image (#2364). Add build args to select the build script and mono version to use. Remove deprecated MAINTAINER instruction and add metadata with LABEL (#2361). Add "choco.exe" to path, so both "choco" and "choco.exe" can be used, like Windows supports (#2362). Change the install location to "/opt/chocolatey" as that is more in line with the Linux filesystem hierarchy (#2360). Create the "lib" directory to prevent the warning about the directory not being found (#2363). The choco_official_wrapper is used for official builds, where the "--allow-unofficial" argument is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be good to add metadata to the docker container. The opencontainer spec for labeling probably should be used: https://github.com/opencontainers/image-spec/blob/main/annotations.md
Part of this is to update the maintainer information, as per the Dockerfile reference, the
MAINTAINERinstruction is deprecated. Instead, the maintainer should be set through theLABELinstruction.The text was updated successfully, but these errors were encountered: