Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-564) ensure ExitCode is populated #569

Merged
merged 1 commit into from
Jun 29, 2024
Merged

(GH-564) ensure ExitCode is populated #569

merged 1 commit into from
Jun 29, 2024

Conversation

mwallner
Copy link
Member

@mwallner mwallner commented Jun 28, 2024 •
edited
Loading

Description Of Changes

Hold on handle of created process to ensure 'ExitCode' get's correctly populated.
See PowerShell/PowerShell#20400

Testing

Tested on Server2019 Vagrant VM, works

image

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

Fixes #564

@mwallner mwallner requested a review from flcdrg June 28, 2024 19:00
flcdrg
flcdrg approved these changes Jun 29, 2024
View reviewed changes
Copy link
Member

@flcdrg flcdrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, the things we have to do!

@flcdrg flcdrg merged commit a86b4c3 into chocolatey:develop Jun 29, 2024
@mwallner mwallner deleted the Task-GH564 branch January 8, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flcdrg flcdrg flcdrg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install-BoxstarterPackage: Errors Array of result object is empty, even if an error occurs
2 participants
@mwallner @flcdrg