Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boxstarter.zip for remote setup doesn't contain compiled modules #579

Closed
5 of 6 tasks
mwallner opened this issue Sep 16, 2024 · 3 comments · Fixed by #580
Closed
5 of 6 tasks

Boxstarter.zip for remote setup doesn't contain compiled modules #579

mwallner opened this issue Sep 16, 2024 · 3 comments · Fixed by #580
Assignees
Labels
Bug Issues where something has happened which was not expected or intended

Comments

@mwallner
Copy link
Member

mwallner commented Sep 16, 2024

Checklist

  • I confirm there are no unresolved issues reported on the Chocolatey Status page.
  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my problem.
  • I have verified this is not an issue for a specific package.
  • I have verified this issue is not security related.
  • I confirm I am using official, and not unofficial, or modified, Chocolatey products.

What You Are Seeing?

When building/ using the latest source from "develop", remote installations fail due to Boxstarter.zip missing the compiled modules.

What is Expected?

The modules in the remote-installation zip should be the same as in the nupkgs.

How Did You Get This To Happen?

use the existing buildscripts in order to create the nupkg/boxstarter.zip files.

./build Package

System Details

Installed Packages

Output Log

Additional Context

introduced with #563

@mwallner mwallner added the Bug Issues where something has happened which was not expected or intended label Sep 16, 2024
@mwallner mwallner self-assigned this Sep 16, 2024
@mwallner mwallner added this to the 3.1.0 milestone Sep 16, 2024
@pauby
Copy link
Member

pauby commented Sep 16, 2024

@mwallner can you complete the template sections fully?

mwallner added a commit to mwallner/boxstarter that referenced this issue Sep 16, 2024
@mwallner mwallner changed the title (develop branch) Boxstarter.zip for remote setup doesn't contain compiled modules Boxstarter.zip for remote setup doesn't contain compiled modules Sep 16, 2024
@mwallner mwallner removed this from the 3.1.0 milestone Sep 16, 2024
@mwallner
Copy link
Member Author

@mwallner can you complete the template sections fully?

sorry, not sure how to do this with an already-created issue...

tbh, I was unsure on how to proceed with this, since this is a fix/issue for something that's not yet included in a release. (#565 has been merged but is incomplete without this addition/fix)

@pauby
Copy link
Member

pauby commented Sep 16, 2024

sorry, not sure how to do this with an already-created issue...

You just need to edit the description, put back all the sections removed and add in the information requested. The template should not be edited to remove sections.

tbh, I was unsure on how to proceed with this,

This should just be completed as a normal issue.

mwallner added a commit to mwallner/boxstarter that referenced this issue Sep 26, 2024
mwallner added a commit that referenced this issue Sep 27, 2024
* GH-579: include compiled modules in Boxstarter.zip

* (maint) typo in buildscript - tag is not recognized

* GH-579: ensure Boxstarter.zip is included in nupkg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues where something has happened which was not expected or intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants