Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Ghostscript*) Migrated to AU+ Modernized #648

Merged
merged 4 commits into from
Mar 31, 2017
Merged

(Ghostscript*) Migrated to AU+ Modernized #648

merged 4 commits into from
Mar 31, 2017

Conversation

AdmiringWorm
Copy link
Member

requires [AU ghostscript*] in merge title

Copy link
Member

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if we keep the identifier with starting upper case letter for compatibility reasons, I would suggest to use all lower case for the folder names (eg. GitHub sorts directories starting with an upper case letter before the ones with a lower case letter)

<id>{{PackageName}}</id>
<version>{{PackageVersion}}</version>
<title>Ghostscript (Install)</title>
<id>Ghostscript.app</id>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change to lower case without breaking stuff?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could always set the PackageName in the update.ps1 file.
But if we do, au won't be able to commit the files with git because of majkinetor/au#66 and because git is case sensitive.

<docsUrl>http://www.ghostscript.com/doc/9.21/Readme.htm</docsUrl>
<bugTrackerUrl>https://bugs.ghostscript.com/</bugTrackerUrl>
<tags>ghostscript.app ghostscript postscript admin foss cross-platform</tags>
<summary>an interpreter for the PostScript language and for PDF.</summary>
<description>
Ghostscript is a package of software that provides:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Features heading for the list?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, if you can't find a page where they list the features then sure.
I couldn't find it, and I'm not really familiar with ghostscript (never used it myself, only heard of it on several occasions).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about just adding the Features heading above the existing list, which look to me already like a feature list. But not required for me

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, I didn't actually look too closely on the existing description.
I'll have a look at it and see if it's suited to be in a features list.

<id>{{PackageName}}</id>
<version>{{PackageVersion}}</version>
<title>Ghostscript</title>
<id>Ghostscript</id>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change to lower case without breaking stuff?

<docsUrl>http://www.ghostscript.com/doc/9.21/Readme.htm</docsUrl>
<bugTrackerUrl>https://bugs.ghostscript.com/</bugTrackerUrl>
<tags>ghostscript.app ghostscript postscript admin foss cross-platform</tags>
<summary>an interpreter for the PostScript language and for PDF.</summary>
<description>
Ghostscript is a package of software that provides:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Features heading for the list?

@AdmiringWorm
Copy link
Member Author

@pascalberger I've updated the description.
I'm still unsure of changing the directory name to lowercase though.

@pascalberger
Copy link
Member

pascalberger commented Mar 31, 2017

@AdmiringWorm I'm also not sure about folder name. I'm always confused while browsing the repo on GitHub since it is ordered case-sensitive, but I also see the point in having folder names identical to package id. So I'll approve it and you can decide what you prefer 😄

@AdmiringWorm
Copy link
Member Author

@pascalberger I think I would leave the folder name as is for now, when either majkinetor/au#66 or chocolatey/choco#1040 is fixed, then I think it's fine to change the folder name.

@AdmiringWorm AdmiringWorm merged commit e147f06 into master Mar 31, 2017
@AdmiringWorm AdmiringWorm deleted the Ghostscript branch March 31, 2017 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants