-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(selenium.powershell) Adds selenium.powershell #2460
(selenium.powershell) Adds selenium.powershell #2460
Conversation
❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things to be fixed up, please also keep things consistent with existing code style in the repository.
✅ Package verification completed without issues. PR is now pending human review |
ef37f6a
to
1f8206a
Compare
I've updated the code based on the review comments @AdmiringWorm. |
✅ Package verification completed without issues. PR is now pending human review |
c9cb443
to
bf62ecf
Compare
✅ Package verification completed without issues. PR is now pending human review |
bf62ecf
to
079a8b5
Compare
✅ Package verification completed without issues. PR is now pending human review |
This contains the Selenium module. It is updated from the PowerShell gallery releases, and there are not currently plans to run a prerelease stream. Co-authored-by: James Ruskin <james@chocolatey.io>
079a8b5
to
6468471
Compare
✅ Package verification completed without issues. PR is now pending human review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but once merged we need to monitor the submission.
If the ID is flagged on CCR, we should change the identifier (not sure to what).
Description
This new package contains the Selenium module.
It is updated from the PowerShell gallery releases, and there are not currently plans to run a prerelease stream.
Please note that there is some outstanding conversation about the correct category tag to use, and that the update script is interesting in that it adds verification for each and every file within the module. This doesn't fit nicely with any of our examples, as this is the first PowerShell module to be added to this repository.
Motivation and Context
As part of #1904, it was decided to migrate packages we depend on to the Chocolatey Community Chocolatey Packages Git repository. This package was included as wanted, but wasn't actually a pre-existing package.
Fixes #2179.
How Has this Been Tested?
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)[ ] Breaking change (fix or feature that would cause existing functionality to change)[ ] Migrated package (a package has been migrated from another repository)Checklist:
[ ] My change requires a change to documentation (this usually means the notes in the description of a package).[ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).