Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(selenium.powershell) Adds selenium.powershell #2460

Merged

Conversation

corbob
Copy link
Contributor

@corbob corbob commented Apr 22, 2024

Description

This new package contains the Selenium module.

It is updated from the PowerShell gallery releases, and there are not currently plans to run a prerelease stream.

Please note that there is some outstanding conversation about the correct category tag to use, and that the update script is interesting in that it adds verification for each and every file within the module. This doesn't fit nicely with any of our examples, as this is the first PowerShell module to be added to this repository.

Motivation and Context

As part of #1904, it was decided to migrate packages we depend on to the Chocolatey Community Chocolatey Packages Git repository. This package was included as wanted, but wasn't actually a pre-existing package.

Fixes #2179.

How Has this Been Tested?

  • Pack package / run Update.ps1 / Update_all.ps1 selenium.powershell
  • Tested installation of package without arguments
  • Tested uninstallation of package
  • Tested install of package with arguments (both individually and together)
  • Observed expected results
  • Tested uninstall with both arguments
  • Tested uninstall with the module being loaded in a PowerShell session
  • Observed that module files are not removed and warning message advises what is needed

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • [ ] My change requires a change to documentation (this usually means the notes in the description of a package).
  • [ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the chocolatey test environment.
  • The changes only affect a single package (not including meta package).

@AppVeyorBot
Copy link

❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to be fixed up, please also keep things consistent with existing code style in the repository.

automatic/selenium.powershell/tools/chocolateyInstall.ps1 Outdated Show resolved Hide resolved
automatic/selenium.powershell/tools/chocolateyInstall.ps1 Outdated Show resolved Hide resolved
automatic/selenium.powershell/tools/chocolateyInstall.ps1 Outdated Show resolved Hide resolved
automatic/selenium.powershell/update.ps1 Outdated Show resolved Hide resolved
automatic/selenium.powershell/update.ps1 Outdated Show resolved Hide resolved
automatic/selenium.powershell/README.md Show resolved Hide resolved
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@corbob corbob requested a review from AdmiringWorm April 24, 2024 20:32
@corbob corbob force-pushed the 2179-AddsSeleniumPowerShell branch from ef37f6a to 1f8206a Compare April 24, 2024 20:42
@corbob
Copy link
Contributor Author

corbob commented Apr 24, 2024

I've updated the code based on the review comments @AdmiringWorm.

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@corbob corbob force-pushed the 2179-AddsSeleniumPowerShell branch 2 times, most recently from c9cb443 to bf62ecf Compare April 25, 2024 23:48
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@corbob corbob force-pushed the 2179-AddsSeleniumPowerShell branch from bf62ecf to 079a8b5 Compare April 26, 2024 02:33
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

corbob and others added 2 commits April 30, 2024 16:56
This contains the Selenium module.

It is updated from the PowerShell gallery releases, and there are not currently plans to run a prerelease stream.

Co-authored-by: James Ruskin <james@chocolatey.io>
@corbob corbob force-pushed the 2179-AddsSeleniumPowerShell branch from 079a8b5 to 6468471 Compare May 1, 2024 00:01
@corbob corbob requested a review from AdmiringWorm May 1, 2024 00:01
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but once merged we need to monitor the submission.

If the ID is flagged on CCR, we should change the identifier (not sure to what).

@AdmiringWorm AdmiringWorm merged commit 5d965c8 into chocolatey-community:master May 3, 2024
1 check passed
@corbob corbob deleted the 2179-AddsSeleniumPowerShell branch May 3, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Selenium PowerShell Module package
4 participants