Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(azcopy10) Migrate package to new repository #2336

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

corbob
Copy link
Contributor

@corbob corbob commented Oct 31, 2023

Description

This pull request adds the azcopy10 package which pauby is currently a maintainer for.

Motivation and Context

As part of the effort to maintain critical Chocolatey packages, this package is being moved to the Chocolatey Community Chocolatey Packages GitHub Repository.

How Has this Been Tested?

  1. Normal installation and uninstallation through the chocolatey-test-environment
  2. running update.ps1 directly in a Windows 10 VM.

Screenshot (if appropriate, usually isn't needed):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the chocolatey test environment.
  • The changes only affect a single package (not including meta package).

Original Location

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

automatic/azcopy10/azcopy10.nuspec Outdated Show resolved Hide resolved
automatic/azcopy10/azcopy10.nuspec Outdated Show resolved Hide resolved
@jbpaux
Copy link

jbpaux commented Oct 31, 2023

More other, as the (very) old azcopy package is I think barely used anymore, shouldn't we considerate :

  • Replace azcopy package with content of azcopy10 package (and maybe create an azcopy8 package with old content if people still want to use an old version)
  • Publish azcopy 10.X as azcopy package
  • "Deprecate" azcopy10 package by putting it as a dependency of azcopy package so people can migrate to it

What do you all think ? @pauby ?

@pauby
Copy link
Member

pauby commented Oct 31, 2023

@jbpaux I think we should discuss that over on #1904 as it doesn't affect the PR.

* Add to CODEOWNERS file
* Update owner in nuspec
* Update package source in nuspec
* Move icon to icons directory
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@corbob corbob marked this pull request as ready for review December 4, 2023 18:48
@corbob
Copy link
Contributor Author

corbob commented Dec 4, 2023

I believe this is ready for review now. It will need the package maintainers on Chocolatey Community Repository updated to include chocolatey-comunity

@jbpaux
Copy link

jbpaux commented Dec 19, 2023

Done @corbob (you miss the second m in chocolatey-community I think but I fixed it). It's pending approval.

@pauby
Copy link
Member

pauby commented Dec 21, 2023

Tested this and update, install and uninstall work fine. I've added chocolatey-community user to the package, removed @jbpaux, and I've left myself there until the first package is published, just in case. After that I'm happy to be removed.

@jbpaux Thank you very much for all your hard work with this package. And thank you for your patience while I tried to find the time to migrate.

Thank you @corbob for migrating this package over.

@pauby pauby merged commit d68de88 into chocolatey-community:master Dec 21, 2023
@corbob corbob deleted the add-azcopy10 branch December 21, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants