-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(jenkins) Adds Jenkins package #2064
(jenkins) Adds Jenkins package #2064
Conversation
❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look. |
Apologies, apparently I only tested in PS7. One moment! |
62eafb0
to
ffa3899
Compare
✅ Package verification completed without issues. PR is now pending human review |
I forgot one thing, remember to add this package to the code owners file as well. |
Dear contributor, As this PR seems to have been inactive for 30 days after changes or additional information |
I seem unable to reopen this PR, so will create a new one. I think I have addressed all comments made in this other than the copyright one. |
Description
This migrates the
jenkins
package to the community packages GitHub repository.It also has some odd upgrade logic within the package, due to the changes to the MSI installer in the meantime. This should be reviewed carefully.
The single most annoying part of this change is that we have moved from an embedded version of JRE to requiring a separate install - however, we feel that we cannot enforce a single specific dependency. We have ensured that the package will fail if we can't find a version of JRE, but this may still result in unexpected failures in
upgrade all
scenarios that are pointing at CCR.I'm very happy to discuss this further, though the way it is now reflects a lot of offline conversation.
Motivation and Context
This package migrates a "critical Chocolatey Software package" to this community maintained repository.
Adds to #1904
How Has this Been Tested?
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)[ ] New feature (non-breaking change which adds functionality)[ ] Breaking change (fix or feature that would cause existing functionality to change)Checklist:
[ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).[ ] I have updated the package description and it is less than 4000 characters.Original Location