Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(jenkins) Adds Jenkins package #2064

Closed

Conversation

JPRuskin
Copy link
Contributor

@JPRuskin JPRuskin commented Nov 15, 2022

Description

This migrates the jenkins package to the community packages GitHub repository.

It also has some odd upgrade logic within the package, due to the changes to the MSI installer in the meantime. This should be reviewed carefully.

The single most annoying part of this change is that we have moved from an embedded version of JRE to requiring a separate install - however, we feel that we cannot enforce a single specific dependency. We have ensured that the package will fail if we can't find a version of JRE, but this may still result in unexpected failures in upgrade all scenarios that are pointing at CCR.

I'm very happy to discuss this further, though the way it is now reflects a lot of offline conversation.

Motivation and Context

This package migrates a "critical Chocolatey Software package" to this community maintained repository.

Adds to #1904

How Has this Been Tested?

  • Tested the update script locally
  • Tested installing the upgrade package over the last available CCR version
  • Tested installing the package clean

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • [ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • [ ] I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the chocolatey test environment.
  • The changes only affect a single package (not including meta package).

Original Location

  • Original Repository: Chocolatey Internal Automatic Packages Repository
  • Internal: Please see !13
  • The migration guidelines have been followed

@AppVeyorBot
Copy link

❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

@JPRuskin
Copy link
Contributor Author

Apologies, apparently I only tested in PS7. One moment!

@JPRuskin JPRuskin force-pushed the ENGTASKS-1599/jenkins branch from 62eafb0 to ffa3899 Compare November 15, 2022 13:46
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

automatic/jenkins/ReadMe.md Show resolved Hide resolved
automatic/jenkins/ReadMe.md Show resolved Hide resolved
automatic/jenkins/ReadMe.md Show resolved Hide resolved
automatic/jenkins/ReadMe.md Show resolved Hide resolved
automatic/jenkins/ReadMe.md Show resolved Hide resolved
automatic/jenkins/jenkins.nuspec Show resolved Hide resolved
automatic/jenkins/jenkins.nuspec Show resolved Hide resolved
automatic/jenkins/tools/LICENSE.txt Show resolved Hide resolved
automatic/jenkins/tools/VERIFICATION.txt Show resolved Hide resolved
automatic/jenkins/tools/chocolateyinstall.ps1 Show resolved Hide resolved
@AdmiringWorm
Copy link
Member

I forgot one thing, remember to add this package to the code owners file as well.

@github-actions
Copy link

Dear contributor,

As this PR seems to have been inactive for 30 days after changes or additional information
was requested, I've automatically closed it.
If you feel the changes are still valid, please re-open the PR once all changes or additional information
that was requested has been added.
Thank you for your contribution.

@JPRuskin
Copy link
Contributor Author

I seem unable to reopen this PR, so will create a new one. I think I have addressed all comments made in this other than the copyright one.

@JPRuskin JPRuskin mentioned this pull request Mar 16, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants