Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(kubernetes-cli) Update to the latest supported versions #1952

Merged
merged 2 commits into from
Aug 2, 2022
Merged

(kubernetes-cli) Update to the latest supported versions #1952

merged 2 commits into from
Aug 2, 2022

Conversation

rgl
Copy link
Contributor

@rgl rgl commented Jul 21, 2022

Description

Update kubernetes-cli to the latest supported versions.

Motivation and Context

See #1901 (reply in thread)

How Has this Been Tested?

I've tested (un)installing in my machine.

Screenshot (if appropriate, usually isn't needed):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the chocolatey test environment.
  • The changes only affect a single package (not including meta package).

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

TheCakeIsNaOH
TheCakeIsNaOH reviewed Jul 21, 2022
View reviewed changes
automatic/kubernetes-cli/update.ps1 Outdated Show resolved Hide resolved
automatic/kubernetes-cli/kubernetes-cli.json Outdated Show resolved Hide resolved
automatic/kubernetes-cli/kubernetes-cli.nuspec Outdated Show resolved Hide resolved
automatic/kubernetes-cli/legal/VERIFICATION.txt Outdated Show resolved Hide resolved
@rgl rgl force-pushed the rgl-update-kubernetes-cli branch from db4fa3c to f9f1e84 Compare July 23, 2022 15:24
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

TheCakeIsNaOH
TheCakeIsNaOH reviewed Jul 23, 2022
View reviewed changes
Copy link
Member

@TheCakeIsNaOH TheCakeIsNaOH left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this, there is still the one open question, but maybe someon else has thoughts?

@rgl rgl force-pushed the rgl-update-kubernetes-cli branch from f9f1e84 to 4f0b6f0 Compare July 23, 2022 20:09
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@rgl
Copy link
Contributor Author

rgl commented Jul 23, 2022

Thanks for updating this, there is still the one open question, but maybe someon else has thoughts?

It should be fixed now. Please verify.

AdmiringWorm
AdmiringWorm requested changes Jul 25, 2022
View reviewed changes
automatic/kubernetes-cli/update.ps1 Outdated Show resolved Hide resolved
automatic/kubernetes-cli/update.ps1 Outdated Show resolved Hide resolved
automatic/kubernetes-cli/update.ps1 Show resolved Hide resolved
@rgl rgl force-pushed the rgl-update-kubernetes-cli branch from 4f0b6f0 to 09036de Compare July 25, 2022 18:31
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@rgl rgl force-pushed the rgl-update-kubernetes-cli branch from 09036de to a172847 Compare July 25, 2022 18:37
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@rgl rgl force-pushed the rgl-update-kubernetes-cli branch from a172847 to 70c67ec Compare August 1, 2022 19:46
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@AdmiringWorm
(kubernetes-cli) Update stream limit
66d5224 
The limit will be set to 10 until as this is the maximum
amount of versions that can be in a submitted queue for a single
package on community.chocolatey.org. Once the packages have been
approved the limit can be increased and/or removed so we have
all of the versions available on community.chocolatey.org
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

AdmiringWorm
AdmiringWorm approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have updated the stream limit to 10 packages. I would normally remove the limit, but it seems we are missing quite a few versions on community.chocolatey.org which exceeds the number of versions that can be in the submitted queue.

@AdmiringWorm AdmiringWorm merged commit ecd690b into chocolatey-community:master Aug 2, 2022
@rgl
Copy link
Contributor Author

rgl commented Aug 4, 2022

Any idea why https://community.chocolatey.org/packages/kubernetes-cli still does not have the latest versions?

@AdmiringWorm
Copy link
Member

Seems that the latest version failed to be pushed to the Community Chocolatey Repository, but AU did not see it as an error. I'll get the stream for that version reset so it will try it again.

@rgl
Copy link
Contributor Author

rgl commented Aug 9, 2022

It has worked. 1.24.3 is now available. Thanks for looking into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheCakeIsNaOH TheCakeIsNaOH TheCakeIsNaOH left review comments

@AdmiringWorm AdmiringWorm AdmiringWorm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rgl @AppVeyorBot @AdmiringWorm @TheCakeIsNaOH