Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Ensure PS v2 compatibility #14

Merged
merged 1 commit into from
Jul 6, 2023
Merged

(fix) Ensure PS v2 compatibility #14

merged 1 commit into from
Jul 6, 2023

Conversation

pauby
Copy link
Member

@pauby pauby commented Jul 5, 2023 •
edited
Loading

The current code does not work in PowerShell v2.

image

This change ensures it does.

image

@pauby pauby requested a review from vexx32 July 5, 2023 10:52
vexx32
vexx32 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! There's a few ways we could go here but ultimately... whatever works! :3

src/chocolatey-compatibility.extension/extensions/chocolatey-compatibility.psm1 Show resolved Hide resolved
@vexx32 vexx32 merged commit 9a91ef4 into chocolatey-community:master Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vexx32 vexx32 vexx32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pauby @vexx32