Skip to content

Commit

Permalink
Add the thrown notice to all Ajax controlers in the tax module
Browse files Browse the repository at this point in the history
  • Loading branch information
dmanners committed Aug 3, 2017
1 parent 66f1460 commit d27cf63
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ public function __construct(
* Get rates page via AJAX
*
* @return Json
* @throws \InvalidArgumentException
*/
public function execute()
{
Expand Down
2 changes: 2 additions & 0 deletions app/code/Magento/Tax/Controller/Adminhtml/Tax/AjaxDelete.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ class AjaxDelete extends \Magento\Tax\Controller\Adminhtml\Tax
* Delete Tax Class via AJAX
*
* @return \Magento\Framework\Controller\Result\Json
* @throws \InvalidArgumentException
*/
public function execute()
{
Expand All @@ -29,6 +30,7 @@ public function execute()
'error_message' => __('We can\'t delete this tax class right now.')
];
}

/** @var \Magento\Framework\Controller\Result\Json $resultJson */
$resultJson = $this->resultFactory->create(ResultFactory::TYPE_JSON);
$resultJson->setData($responseContent);
Expand Down
2 changes: 2 additions & 0 deletions app/code/Magento/Tax/Controller/Adminhtml/Tax/AjaxSave.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ class AjaxSave extends \Magento\Tax\Controller\Adminhtml\Tax
* Save Tax Class via AJAX
*
* @return \Magento\Framework\Controller\Result\Json
* @throws \InvalidArgumentException
*/
public function execute()
{
Expand Down Expand Up @@ -47,6 +48,7 @@ public function execute()
'class_name' => '',
];
}

/** @var \Magento\Framework\Controller\Result\Json $resultJson */
$resultJson = $this->resultFactory->create(ResultFactory::TYPE_JSON);
$resultJson->setData($responseContent);
Expand Down

0 comments on commit d27cf63

Please sign in to comment.