Merge pull request #242 from chmp/feature/errors-for-non-self-describ…

…ing-types Improve errors for non self describing types
chmp · Sep 30, 2024 · a3f3970 · a3f3970
2 parents 3de848d + cb946c1
commit a3f3970
Show file tree

Hide file tree

Showing 6 changed files with 123 additions and 57 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Changes.md b/Changes.md
@@ -6,6 +6,8 @@ New features
 
 - Add support to auto-detect dates (`2024-09-30`, mapped to `Date32`) and times (`12:00:00`, mapped
   to `Time64(Nanosecond))`) in `from_samples`
+- Improved error messages for non self describing types (`chrono::*`, `uuid::Uuid`,
+  `std::net::IpAddr`)
 
 ## 0.12.0
 

diff --git a/serde_arrow/src/internal/error.rs b/serde_arrow/src/internal/error.rs
@@ -135,15 +135,21 @@ impl Error {
             Self::Custom(err) => Some(&err.0.annotations),
         }
     }
+
+    pub(crate) fn modify_message<F: FnOnce(&mut String)>(&mut self, func: F) {
+        let Error::Custom(this) = self;
+        let inner = this.0.as_mut();
+        func(&mut inner.message);
+    }
 }
 
 #[derive(PartialEq)]
 pub struct CustomError(pub(crate) Box<CustomErrorImpl>);
 
 pub struct CustomErrorImpl {
-    message: String,
-    backtrace: Backtrace,
-    cause: Option<Box<dyn std::error::Error + Send + Sync + 'static>>,
+    pub(crate) message: String,
+    pub(crate) backtrace: Backtrace,
+    pub(crate) cause: Option<Box<dyn std::error::Error + Send + Sync + 'static>>,
     pub(crate) annotations: BTreeMap<String, String>,
 }