-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(make): exclude makefile variable from completion and handle multiple targets in a rule #248
Conversation
@chitoku-k done, upgraded the regex to deal with one more case |
@braineo Seems good! Could you also update the test case ( |
no problem. TIL. interesting behavior difference for gawk and mawk, i wrote 3 different versions of the same awk script |
as for the comment that's my personal habit. i always forget why i wrote the (slightly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL. interesting behavior difference for gawk and mawk, i wrote 3 different versions of the same awk script
That’s why I set up CI to ensure the same behavior across the different implementations. It seemed like it helped debugging here.
Regarding the comment, I’m pretty fine with them as long as there are test cases that cover that. Thank you for your contribution!
https://ftp.gnu.org/old-gnu/Manuals/make-3.79.1/html_chapter/make_6.html
Makefile variables can be defined as
this change uses negative lookahead to exclude
:=
patternsalso added support for multi-target case
https://www.gnu.org/software/make/manual/html_node/Multiple-Targets.html