Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vector-units w/o L1D$ access #3537

Merged
merged 3 commits into from
Nov 25, 2023
Merged

Support vector-units w/o L1D$ access #3537

merged 3 commits into from
Nov 25, 2023

Conversation

sequencer
Copy link
Member

@sequencer sequencer commented Nov 23, 2023

Without upstreaming these patches, T1 cannot elaborate... We need decouple in the future. Since there is no current valid useVector implementations, I think this is safe to merge.

Related issue:

Type of change: bug report | feature request | other enhancement

Impact: no functional change | API addition (no impact on existing code) | API modification

Development Phase: proposal | implementation

Release Notes

@sequencer sequencer requested a review from jerryz123 November 23, 2023 17:35
@sequencer sequencer changed the title remove vMemDataBits check Hotfix for Vector Nov 23, 2023
sequencer added a commit to chipsalliance/t1 that referenced this pull request Nov 23, 2023
Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My implementation requires this.
We can add another flag usingVectorDCache

@sequencer
Copy link
Member Author

My implementation requires this.
We can add another flag usingVectorDCache

Added vectorUseDCache

@jerryz123 jerryz123 changed the title Hotfix for Vector Support vector-units w/o L1D$ access Nov 25, 2023
Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I appreciate it

@sequencer
Copy link
Member Author

We should purge these uArch parameters dependencies eventually. But not now;p

@sequencer sequencer merged commit b3fa8df into dev Nov 25, 2023
@sequencer sequencer deleted the vec-hotfix branch November 25, 2023 08:59
@jerryz123
Copy link
Contributor

@Mergifyio copy master

Copy link
Contributor

mergify bot commented Nov 25, 2023

copy master

✅ Pull request copies have been created

@jerryz123
Copy link
Contributor

@Mergifyio copy master

Copy link
Contributor

mergify bot commented Nov 25, 2023

copy master

✅ Pull request copies have been created

Avimitin pushed a commit to chipsalliance/t1 that referenced this pull request Dec 5, 2023
Avimitin pushed a commit to chipsalliance/t1 that referenced this pull request Dec 5, 2023
Avimitin pushed a commit to chipsalliance/t1 that referenced this pull request Dec 12, 2023
jerryz123 added a commit that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants