This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
Add missing ResolveKinds/ResolveFlows invalidates #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32c6252 to
1cf3321
Compare
Update the dependencies of transforms which empirically invalidate ResolveKinds or ResolveFlows. This was discovered with some to-be-committed work that automates looking for incorrect transform dependencies. Specifically, the deficient transforms were found to not invalidate ResolveKinds or ResolveFlows, yet running ReslveKinds or ResolveFlows after these transforms would result in modifications to the circuit. The LoweringCompilersSpec was updated with patches to indicate the location of these new transforms. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
1cf3321 to
f5e7c2e
Compare
ekiwi-sifive
suggested changes
Jul 27, 2020
| @@ -133,7 +134,7 @@ class FlattenRegUpdate extends Transform with DependencyAPIMigration { | |||
| override def optionalPrerequisiteOf = Seq.empty | |||
|
|
|||
| override def invalidates(a: Transform): Boolean = a match { | |||
| case _: DeadCodeElimination => true | |||
| case _: DeadCodeElimination | ResolveKinds => true | |||
There was a problem hiding this comment.
This can probably be fixed by adding the correct kind (RegKind) to the WRef created on line 100.
| @@ -53,7 +53,7 @@ class DeadCodeElimination extends Transform | |||
| Dependency(passes.VerilogPrep), | |||
| Dependency[firrtl.AddDescriptionNodes] ) | |||
|
|
|||
| override def invalidates(a: Transform) = false | |||
| override def invalidates(a: Transform) = a == ResolveKinds | |||
There was a problem hiding this comment.
Do you know if this had anything todo with the use of ExprKind instead of MemKind on line 134?
| @@ -175,7 +175,7 @@ object VerilogMemDelays extends Pass { | |||
| Dependency[SystemVerilogEmitter] ) | |||
|
|
|||
| override def invalidates(a: Transform): Boolean = a match { | |||
| case _: transforms.ConstantPropagation | ResolveFlows => true | |||
| case _: transforms.ConstantPropagation | ResolveFlows | ResolveKinds => true | |||
There was a problem hiding this comment.
This one is interesting because the one WRef it seems to create actually appears to have the correct kind (RegKind).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the dependencies of transforms which empirically invalidate
ResolveKinds or ResolveFlows.
This was discovered with some to-be-committed work that automates
looking for incorrect transform dependencies. Specifically, the
deficient transforms were found to not invalidate ResolveKinds or
ResolveFlows, yet running ReslveKinds or ResolveFlows after these
transforms would result in modifications to the circuit.
The LoweringCompilersSpec was updated with patches to indicate the
location of these new transforms.
Depends on: [#1753, #1754]
This should be backported to 1.3.x, but will need to be done manually.
Contributor Checklist
Type of Improvement
API Impact
None.
Backend Code Generation Impact
None.
Desired Merge Strategy
Release Notes
None.
Reviewer Checklist (only modified by reviewer)
Please Merge?