Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn on S-interpolator usage for assert, assume and printf (backport #2751) #2757

Merged
merged 4 commits into from
Nov 10, 2022
Merged

Warn on S-interpolator usage for assert, assume and printf (backport #2751) #2757

merged 4 commits into from
Nov 10, 2022

Conversation

adkian-sifive
Copy link
Contributor

Backport of #2751, change errors to warnings for usages of s-interpolators

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

API Impact

Backend Code Generation Impact

Desired Merge Strategy

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@adkian-sifive adkian-sifive force-pushed the s-interpolator-warn-bp branch from c11342f to e2a4c16 Compare October 19, 2022 00:14
@adkian-sifive
Add macro to intercept s-interpolator uses
f79f19e 
Clean up warnings

Add macros to assume and printf

Update src/test/scala/chiselTests/Vec.scala

Co-authored-by: Megan Wachs <megan@sifive.com>

Fix formatting

Change warning to error

Update a callsite. Rename function in Printf.scala to match the naming
convention in the file. Undo call by name change to preserve binary compatibility.

Fix IntervalSpec tests

Update printing docs to include new warning

Add failing example to docs

Better docs for the error

Update error message to not mention the p-interpolator

Minor tweaks to error message and docs.

Run scalafmt

Switch errors to warning for bp
@adkian-sifive
Add internal methods to maintain binary compatibility
5435097
@adkian-sifive
Update build.sbt and add deprecation warnings to Printf.apply methods
307faa2
@jackkoenig jackkoenig enabled auto-merge (squash) November 10, 2022 21:27
@jackkoenig jackkoenig merged commit c51fcfe into chipsalliance:3.5.x Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adkian-sifive @jackkoenig