Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aes] Connect EDN interface #700

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

vogelpi
Copy link
Contributor

@vogelpi vogelpi commented Jan 20, 2025

This PR connects the entropy distribution network (EDN) interface of AES to a Trivium stream cipher primitive which can be reseeded by firmware. The stream cipher primitive is required to decouple AES from firmware as AES can repeatedly request fresh entropy via the EDN interface while doing encryptions/decryptions. This entropy is required for the internal masking SCA countermeasure.

Copy link

linux-foundation-easycla bot commented Jan 20, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@vogelpi
Copy link
Contributor Author

vogelpi commented Jan 31, 2025

Update: I've now reworked the firwmare interface as proposed @mojtaba-bisheh . There are now 9 distinct 32-bit registers that firmware writes to provide a new 288-bit seed for the Trivium stream cipher primitive.

mojtaba-bisheh
mojtaba-bisheh previously approved these changes Jan 31, 2025
@vogelpi
Copy link
Contributor Author

vogelpi commented Feb 28, 2025

Hi @mojtaba-bisheh
would you mind approving this please? IIUC this PR needs to be approved by you as well. On top of that, can you please provide some guidance to me and @andrea-caforio for pushing this over the finish line? I think this really needs to be merged before carving the next release.

@mojtaba-bisheh
Copy link
Contributor

Hi @mojtaba-bisheh would you mind approving this please? IIUC this PR needs to be approved by you as well. On top of that, can you please provide some guidance to me and @andrea-caforio for pushing this over the finish line? I think this really needs to be merged before carving the next release.

We need to process it through our internal tools to verify it passes all tests. If you don’t have access to our pipeline, I can handle it for you.

@mojtaba-bisheh mojtaba-bisheh changed the base branch from main to msft-daily-20250228 February 28, 2025 15:09
@vogelpi
Copy link
Contributor Author

vogelpi commented Feb 28, 2025

Hi @mojtaba-bisheh , thanks for your feedback. I don't have access yet, if you could help that would be very much appreciated.

@mojtaba-bisheh
Copy link
Contributor

Hi @mojtaba-bisheh , thanks for your feedback. I don't have access yet, if you could help that would be very much appreciated.

please merge main into this PR to resolve hash conflict. then, I will take care of it

@vogelpi
Copy link
Contributor Author

vogelpi commented Feb 28, 2025

Sorry @mojtaba-bisheh for asking: do you mean to rebase this on main? Can you please provide a list of commands? I am currently traveling and will need to hop on a plane soon.

Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
@mojtaba-bisheh mojtaba-bisheh merged commit 980d7d4 into chipsalliance:msft-daily-20250228 Feb 28, 2025
68 checks passed
calebofearth pushed a commit that referenced this pull request Mar 2, 2025
* [aes] Connect EDN interface

Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>

* [aes] Reseed entropy interface in AES smoketest

Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>

---------

Signed-off-by: Pirmin Vogel <vogelpi@lowrisc.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants