Skip to content

Commit

Permalink
Remove LENB override; fix resp-pipe part-select in axi_sub_wr
Browse files Browse the repository at this point in the history
  • Loading branch information
calebofearth committed Jul 25, 2024
1 parent 2faf5cc commit e50cda0
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 11 deletions.
3 changes: 1 addition & 2 deletions src/axi/rtl/axi_sub_rd.sv
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,7 @@ module axi_sub_rd import axi_pkg::*; #(
// Use full address to calculate next address (in case of arsize < data width)
axi_addr #(
.AW (AW),
.DW (DW),
.LENB(8 )
.DW (DW)
) i_axi_addr (
.i_last_addr(txn_ctx.addr ),
.i_size (txn_ctx.size ), // 1b, 2b, 4b, 8b, etc
Expand Down
17 changes: 8 additions & 9 deletions src/axi/rtl/axi_sub_wr.sv
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,7 @@ module axi_sub_wr import axi_pkg::*; #(
// Use full address to calculate next address (in case of AxSIZE < data width)
axi_addr #(
.AW (AW),
.DW (DW),
.LENB(8 )
.DW (DW)
) i_axi_addr (
.i_last_addr(txn_ctx.addr ),
.i_size (txn_ctx.size ), // 1b, 2b, 4b, 8b, etc
Expand Down Expand Up @@ -285,11 +284,11 @@ module axi_sub_wr import axi_pkg::*; #(
// There is guaranteed to be space in the skid buffer because new
// requests are stalled (AWREADY=0) until this buffer is ready.
always_comb begin
rp_valid = txn_final_beat;
rp_resp[0] = txn_allow && (txn_err || err) ? AXI_RESP_SLVERR :
txn_allow && txn_ctx.lock ? AXI_RESP_EXOKAY :
AXI_RESP_OKAY;
rp_id[0] = txn_ctx.id;
rp_valid = txn_final_beat;
rp_resp = txn_allow && (txn_err || err) ? AXI_RESP_SLVERR :
txn_allow && txn_ctx.lock ? AXI_RESP_EXOKAY :
AXI_RESP_OKAY;
rp_id = txn_ctx.id;
end

skidbuffer #(
Expand All @@ -304,8 +303,8 @@ module axi_sub_wr import axi_pkg::*; #(
.i_reset(!rst_n ),
.i_valid(rp_valid ),
.o_ready(rp_ready ),
.i_data ({rp_resp[0],
rp_id[0]} ),
.i_data ({rp_resp,
rp_id} ),
.o_valid(s_axi_if.bvalid ),
.i_ready(s_axi_if.bready ),
.o_data ({s_axi_if.bresp,
Expand Down

0 comments on commit e50cda0

Please sign in to comment.