Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup after bad errors #259

Closed
wants to merge 3 commits into from

Conversation

drKnoxy
Copy link

@drKnoxy drKnoxy commented Dec 1, 2015

Issue description:

I wasn't able to figure out how to test it, but on IE9 CORS issues just error out with a console message Error: Access is Denied and the module never reaches loaded event. This fixes that.

Issues this addresses

#258, #254, #249

relavent prs

#50

notes

  • if there is no response or response.config that is an indicator of a bad error, we should throw in the towel and call it complete
  • update error messages, log response so we can troubleshoot the issue

@faceleg
Copy link
Collaborator

faceleg commented Mar 2, 2016

I've merged your changes in here: https://github.com/faceleg/angular-loading-bar-plus

I contacted the owner about coming on as a contributor but he hasn't replied. I suggest using my fork as the focus of development from now on.

@faceleg
Copy link
Collaborator

faceleg commented Mar 16, 2016

After understanding how interceptors should work and discussing offline with @chieffancypants, I am in agreement with him that it should not be this module's job to handle incorrect interceptors. I'm therefore closing this.

@faceleg faceleg closed this Mar 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants