Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for bswap of small types #247

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Add support for bswap of small types #247

merged 1 commit into from
Feb 15, 2022

Conversation

rodiazet
Copy link
Collaborator

@rodiazet rodiazet commented Feb 11, 2022 •
edited by chfast
Loading

Add implementation of bswap uint8_t, uint16_t and uint32_t and delete
other overloading. Also add tests for be::unsafe::load to make sure
they work correctly now.

@chfast chfast force-pushed the utility_functions branch 3 times, most recently from c490a36 to 985aa13 Compare February 11, 2022 21:52
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2022 •
edited
Loading

Codecov Report

Merging #247 (910e37b) into master (ceb8640) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 910e37b differs from pull request most recent head ef40d49. Consider uploading reports for the commit ef40d49 to get more accurate results

@@            Coverage Diff            @@
##            master      #247   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines         1847      1896   +49     
=========================================
+ Hits          1847      1896   +49
Flag Coverage Δ
32bit 100.00% <100.00%> (ø)
gcc 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/unittests/test_intx.cpp 100.00% <ø> (ø)
include/intx/intx.hpp 100.00% <100.00%> (ø)
test/unittests/test_builtins.cpp 100.00% <100.00%> (ø)

chfast
chfast reviewed Feb 11, 2022
View reviewed changes
test/unittests/test_builtins.cpp Outdated Show resolved Hide resolved
test/unittests/test_intx.cpp Outdated Show resolved Hide resolved
chfast
chfast requested changes Feb 14, 2022
View reviewed changes
test/unittests/test_builtins.cpp Outdated Show resolved Hide resolved
@chfast chfast changed the title Implementation od bswap for small uint types. Add support for bswap of small types Feb 15, 2022
@rodiazet @chfast
Add support for bswap of small types
ef40d49 
Add implementation of bswap uint8_t, uint16_t and uint32_t and delete
other overloading. Also add tests for be::unsafe::load to make sure
they work correctly now.

Co-Authored-By: Paweł Bylica <pawel@hepcolgum.band>
@chfast chfast merged commit 044b0f8 into master Feb 15, 2022
@chfast chfast deleted the utility_functions branch February 15, 2022 11:57
@rodiazet rodiazet linked an issue Feb 15, 2022 that may be closed by this pull request
Utility functions for small types #246
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfast chfast chfast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Utility functions for small types
3 participants
@rodiazet @codecov-commenter @chfast