Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#692] Add support for Python 3.11. #693

Merged
merged 70 commits into from
Jul 4, 2023
Merged

[#692] Add support for Python 3.11. #693

merged 70 commits into from
Jul 4, 2023

Conversation

adiroiban
Copy link
Member

@adiroiban adiroiban commented May 24, 2023

Scope

Fixes #692

This updates compat to work with Python 3.11.

Changes

Use a newer brink that contains the nose patching for 3.11

How to try and test the changes

reviewers: @dumol

more of a FYI

this is to make sure CI is green on 3.11

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #693 (dee1e84) into master (22902d9) will decrease coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
- Coverage   79.51%   79.47%   -0.05%     
==========================================
  Files          52       52              
  Lines        7797     7800       +3     
  Branches      781     1275     +494     
==========================================
- Hits         6200     6199       -1     
- Misses       1330     1333       +3     
- Partials      267      268       +1     

see 8 files with indirect coverage changes

Components Coverage Δ
tests ∅ <ø> (∅)

@adiroiban
Copy link
Member Author

@dumol can you please review the list of supported OSes for pythia + chevah/compat and see what needs to be done to make this green.

thanks

needs-review

@adiroiban adiroiban requested a review from dumol May 24, 2023 19:26
Copy link
Contributor

@dumol dumol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor fixes for Docker-based testing in my commits above.

Notice that testing specifically on a clone of RHEL 8.2 is no longer required, as we no longer link to the system OpenSSL libs on RHEL 8.

@dumol
Copy link
Contributor

dumol commented Jun 2, 2023

If you merge this into master, I could try re-enabling compat tests in Pythia.

@adiroiban
Copy link
Member Author

I will try to get this merged... this dependes on #132 but that PR is now open for review.
That is the main transition from 2.7 to 3.8

This code over here is the transition from 3.8 to 3.11

thanks

Base automatically changed from 132-py3-migration to master July 4, 2023 09:13
@adiroiban adiroiban merged commit d4a3dfc into master Jul 4, 2023
@adiroiban adiroiban deleted the 692-py3.11-support branch July 4, 2023 17:12
@dumol dumol mentioned this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get python 3.11 working
3 participants