Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chirality remove issue #24

Closed
peiyaoli opened this issue Jul 7, 2021 · 8 comments
Closed

Chirality remove issue #24

peiyaoli opened this issue Jul 7, 2021 · 8 comments

Comments

@peiyaoli
Copy link

peiyaoli commented Jul 7, 2021

Hi, first of all, thanks for open this pipeline which is really helpful for our molecule standardization work.

We came up one question regarding chiralty remove.

Input SMILES: O=C(O)[C@@H]1O[B-]2(O[C@H]1C(=O)O)O[C@@H](C(=O)O)[C@H](C(=O)O)O2

download (3)

after "standardize_mol" and "get_parent_mol", the output molecule is:

OUT SMILES: O=C(O)C1O[B-]2(O[C@H]1C(=O)O)O[C@@H](C(=O)O)[C@H](C(=O)O)O2

It looks like only one chiralty has been removed.
download (4)

@greglandrum How to resolve this issue? Many thanks...

@greglandrum
Copy link
Collaborator

I can reproduce this with standardize_mol():

In [8]: res = standardizer.standardize_mol(Chem.MolFromSmiles('O=C(O)[C@@H]1O[B-]2(O[C@H]1C(=O)O)O[C@@H](C(=O)O)[C@H](C(=O)O)O2'
   ...: ))
[11:21:57] Running Normalizer
[11:21:57] Running Uncharger

In [9]: Chem.MolToSmiles(res)
Out[9]: 'O=C(O)C1O[B-]2(O[C@H]1C(=O)O)O[C@@H](C(=O)O)[C@H](C(=O)O)O2'

but not with get_parent_mol():

In [5]: res,_ = standardizer.get_parent_mol(Chem.MolFromSmiles('O=C(O)[C@@H]1O[B-]2(O[C@H]1C(=O)O)O[C@@H](C(=O)O)[C@H](C(=O)O)O2
   ...: '))
[11:20:57] Running Uncharger
[11:20:57] Running Uncharger

In [6]: Chem.MolToSmiles(res)
Out[6]: 'O=C(O)[C@@H]1O[B-]2(O[C@H]1C(=O)O)O[C@@H](C(=O)O)[C@H](C(=O)O)O2'

I will look into it.

@greglandrum
Copy link
Collaborator

Ok, found it. The problem here is with flatten_tartrate_mol()
Fix on its way

@greglandrum
Copy link
Collaborator

The problem here is caused by errors in the flatten_tartrate() function, which has multiple problems.

greglandrum added a commit to greglandrum/ChEMBL_Structure_Pipeline that referenced this issue Jul 7, 2021
@greglandrum
Copy link
Collaborator

Thanks for reporting this @peiyaoli !

@peiyaoli
Copy link
Author

peiyaoli commented Jul 8, 2021

Welcome~

@eloyfelix
Copy link
Member

Many thanks @peiyaoli for reporting and @greglandrum for the PR! :)

We are planing release a new version of the package for ChEMBL30.

Related to the new version... @greglandrum: will the new RDKit version builds ship with InChI 1.06?

@greglandrum
Copy link
Collaborator

Related to the new version... @greglandrum: will the new RDKit version builds ship with InChI 1.06?

That's definitely something we should do for the 2021.09 release.
Here's the issue: rdkit/rdkit#4322

@eloyfelix
Copy link
Member

that's great, many thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants