Refactoring and code hygiene #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit the internal package for the show cmd was named markdown. In this commit, we rename the package to show so that it matches it's counterpart and is less ambiguous.
This commit addresses a couple of different issues with this package. Previously, everything was lumped in to `client.go`. This was fine initially but it became harder to manage as the codebase grew. Domains are now separated in by file. Future work is probably needed to subdivide each domain in to it's own package to prevent leakage. Secondly, the methods for Tags and Pull were a bit scrappy and not very efficient. This was a left over from the "get it done" phase of the project. These instances have now been resolved and I think the implementation is closed to O(n) (maybe.. either way it's less garbage than it was before).
In this commit we move the template out of the method for readability. Also, because tmpl.Execute returns an error we don't actually need to do error checking in the method. We can just pass the result (error or nil) back to the caller.
df6391f to
5175311
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.