Update the rpm package signing to work with newer rpm version #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of rpmsign (rpm 4.13+), no longer prompt for the pass phrase, but instead provide gpg with access to stdin/out to request it. Because this process is deferred, you will also often end up with warning output from rpmbuild before the prompt, so we can no longer assume the prompt will be the first output. This issue was discovered while trying to build rpm packages for OpenSUSE 15 which has the newer rpm. Signed-off-by: DJ Mountney <david@twkie.net>
|
This isn't ready yet. Works for the new rpmsign, but not the old. Probably because the older one does the prompt without a newline. Will test that now. |
Signed-off-by: DJ Mountney <david@twkie.net>
|
Updated, confirmed this is working for centos 6, centos 7, opensuse 42.3, and opensuse 15 |
|
@twk3 Thanks for the detailed explanation and confirming this doesn't break existing systems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Newer versions of rpmsign (rpm 4.13+), no longer prompt for the pass
phrase, but instead provide gpg with access to stdin/out to request it.
See: rpm-software-management/rpm@0bce5fc#diff-c9c5aab99001a72b592ce7465ebff8a6
Because this process is deferred, you will also often end up with
warning output from rpmbuild before the prompt, so we can no longer
assume the prompt will be the first output.
This issue was discovered while trying to build rpm packages for
OpenSUSE 15 which has the newer rpm.
Maintainers
Please ensure that you check for:
serial number
corresponding change is reviewed and there is a release plan
corresponding change is reviewed and there is a release plan