Cleanup more CI files and sort the list #1115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be every CI file we ship and probably 99% of what exists in the industry as a whole. Signed-off-by: Tim Smith <tsmith@chef.io>
afiune
reviewed
Nov 5, 2019
There was a problem hiding this comment.
Even though these are files, What about directories like .github/?
Example: https://github.com/chef/chef-workstation/tree/master/.github
Also .expeditor/? and .buildkite/?
marcparadise
approved these changes
Nov 5, 2019
|
There's only 1 .github directory in our gem installs and that's in mdl and I cut a PR to remove that, which has been merged. In chef-workstation I did the directory cleanup since that seemed a bit aggressive for all our ruby projects right now. If that doesn't burn us in workstation perhaps we can port that back later. |
tyler-ball
approved these changes
Nov 5, 2019
|
This is related to chef/chef-workstation#672 which is basically this cleanup to the next level. |
Cleanup more CI files and sort the list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be every CI file we ship and probably 99% of what exists in
the industry as a whole.
Signed-off-by: Tim Smith tsmith@chef.io